Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nginx binary classifier #1988

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Create nginx binary classifier #1988

merged 4 commits into from
Aug 3, 2023

Conversation

SemProvoost
Copy link
Contributor

Create nginx binary classifier

Closes #1945

@SemProvoost SemProvoost force-pushed the add-support-for-nginx-binary-version-detection branch from 45f20a8 to cc81b1a Compare August 2, 2023 13:52
@SemProvoost
add support for nginx binary version detection
0a6fbce 
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
@SemProvoost
clarify comments
80815a7 
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
@SemProvoost SemProvoost force-pushed the add-support-for-nginx-binary-version-detection branch from cc81b1a to 80815a7 Compare August 2, 2023 14:28
kzantow
kzantow reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add a couple tests for this? There are a few ways to do this: copy a small amount out of the binary that contains the version, you can see examples of this in the test fixtures here. Alternately, you can extract a binary from a (small, hopefully) image, see examples here.

syft/pkg/cataloger/binary/default_classifiers.go Outdated Show resolved Hide resolved
@SemProvoost
update regex to only fetch the nginx version part
963e065 
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
@SemProvoost
add test cases
cf217a6 
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
kzantow
kzantow approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 👍

@kzantow kzantow merged commit 433a7b8 into anchore:main Aug 3, 2023
9 checks passed
This was referenced Aug 15, 2023
Closed
Merged
Closed
Closed
Closed
Open
Closed
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@SemProvoost
feat: nginx binary classifier (anchore#1988)
e884853 
Signed-off-by: SemProvoost <27961543+SemProvoost@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add binary cataloger for Nginx built from source
2 participants
@SemProvoost @kzantow