fix: correct group IDs for commons-codec, okhttp, okio, and add integration tests for Java PURL generation #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmurphyscode
commented
Aug 29, 2023
test/integration/java_purl_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func getCatalog(t *testing.T, image string) sbom.SBOM { |
There was a problem hiding this comment.
TODO: this should be converted to use the normal test fixture mechanism.
There was a problem hiding this comment.
The Dockerfile in question is here: https://github.com/anchore/test-images/blob/main/containers/java/Dockerfile
I can probably just copy it into a test fixture.
willmurphyscode
commented
Aug 29, 2023
test/integration/java_purl_test.go
Outdated
| "classworlds@1.1": "pkg:maven/org.codehaus.classworlds/classworlds@1.1", | ||
| "cli@1.390": "pkg:maven/org.jvnet.hudson.main/cli@1.390", | ||
| "commons-beanutils@1.8.0": "pkg:maven/commons-beanutils/commons-beanutils@1.8.0", | ||
| "commons-codec@1.2": "pkg:maven/org.apache.commons.codec.*/commons-codec@1.2", |
There was a problem hiding this comment.
TODO: pkg:maven/org.apache.commons.codec.*/commons-codec@1.2 is wrong.
willmurphyscode
commented
Aug 29, 2023
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
willmurphyscode
changed the title
willmurphyscode
commented
Aug 29, 2023
| @@ -0,0 +1 @@ | |||
| FROM anchore/test_images:java-56d52bc | |||
There was a problem hiding this comment.
This is a bit of a hacky way to bring the test fixture into syft. Let me know if it's better to do something else, but I like that this pins the artifact.
There was a problem hiding this comment.
this is the right approach, but should we also use a digest too?
Future commits can hand fix PURLs made for particular packages, and then the map literal here can be edited. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
force-pushed
the
fix-purl-tests
branch
from
d2024ae
to
cb76675
Compare
Signed-off-by: Will Murphy <will.murphy@anchore.com>
wagoodman
approved these changes
Aug 31, 2023
This was referenced Sep 12, 2023
Closed
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ration tests for Java PURL generation (anchore#2075) Add overall integration test for java PURL detection. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future commits can hand fix PURLs made for particular packages, and then the map literal here can be edited.