Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic on universal go binaries #2078

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix: don't panic on universal go binaries #2078

merged 3 commits into from
Aug 30, 2023

Conversation

willmurphyscode
Copy link
Contributor

Fixes #2073

@willmurphyscode
Prevent panic if crypto settings not available on go binary
184180f 
Signed-off-by: Will Murphy <will.murphy@anchore.com>
@willmurphyscode
Rearrange scan go files to make array length mismatch impossible
13ea336 
Signed-off-by: Will Murphy <will.murphy@anchore.com>
@willmurphyscode
remove unnecessary test case
e2bfe3b 
Signed-off-by: Will Murphy <will.murphy@anchore.com>
@willmurphyscode willmurphyscode self-assigned this Aug 30, 2023
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz%0A                                                              │ ./.tmp/benchmark-588feb5.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       13.95m ±  2%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        868.5µ ±  2%25%0AImagePackageCatalogers/binary-cataloger-2                                       247.3µ ±  3%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       765.1µ ±  9%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   27.42µ ±  4%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             132.5µ ±  5%25%0AImagePackageCatalogers/java-cataloger-2                                         21.27m ± 14%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         127.2µ ±  2%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           491.0µ ±  3%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    363.9µ ±  2%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       982.8µ ±  4%25%0AImagePackageCatalogers/portage-cataloger-2                                      610.6µ ±  3%25%0AImagePackageCatalogers/python-package-cataloger-2                               3.948m ±  3%25%0AImagePackageCatalogers/r-package-cataloger-2                                    282.6µ ±  6%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       702.3µ ±  3%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.155m ±  3%25%0AImagePackageCatalogers/sbom-cataloger-2                                         148.2µ ±  6%25%0Ageomean                                                                         623.4µ%0A%0A                                                              │ ./.tmp/benchmark-588feb5.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.133Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        184.4Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.76Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       141.2Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.695Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.891Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         3.070Mi ± 1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.595Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           83.82Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    38.94Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       155.1Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      109.8Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               986.1Ki ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    42.90Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       170.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 123.2Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         93.02Ki%0A%0A                                                              │ ./.tmp/benchmark-588feb5.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.06k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.034k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         866.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        2.911k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               280.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          40.69k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.264k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      820.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        3.845k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.194k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.13k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      851.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.914k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.291k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          1.999k

kzantow
kzantow approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@willmurphyscode willmurphyscode merged commit cfebae2 into main Aug 30, 2023
9 checks passed
@willmurphyscode willmurphyscode deleted the fix-dont-panic-on-universal-go-binaries branch August 30, 2023 12:37
@Porkepix Porkepix mentioned this pull request Aug 31, 2023
Merged
This was referenced Sep 1, 2023
Merged
Closed
Closed
Closed
This was referenced Sep 12, 2023
Closed
Open
Open
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@willmurphyscode
fix: don't panic on universal go binaries (anchore#2078)
fb633af 
If crypto settings or arch cannot be determined, still attempt to catalog packages from
the build info, rather than panicking.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

@willmurphyscode willmurphyscode

Labels
None yet
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.88.0 - runtime error: index out of range [0]
2 participants
@willmurphyscode @kzantow