New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tool management #2188
Upgrade tool management #2188
Conversation
ab6d488
to
8e3943b
Compare
8e3943b
to
f870047
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
f870047
to
4df14d7
Compare
Is it expected that a github token needs to be in the environment to bootstrap after this change? I just checked out the branch and tried ❯ make bootstrap
bash: .tool/task: No such file or directory
bash: .tool/task: No such file or directory
make .tool/task
bash: .tool/task: No such file or directory
bash: .tool/task: No such file or directory
1 error occurred:
* failed to install tool "task": unable to fetch github release go-task/task@v3.30.1: non-200 OK status code: 401 Unauthorized body: "{\"message\":\"Bad credentials\",\"documentation_url\":\"https://docs.github.com/graphql\"}"
make[1]: *** [.tool/task] Error 1
make: *** [bootstrap] Error 2 Am I doing something wrong with this? I checked that I don't have |
edit: GITHUB_TOKEN is no longer required I should have mentioned this up front and updated the DEVELOPING.md docs to highlight this -- this does mean that GITHUB_TOKEN would be required in order to bootstrap the tooling. This is a limitation of the Github v4 GraphQL API. The only other path forward is to have a fallback strategy baked into This is also a good note for binny: if there is no token and we're using the v4 API, dont attempt to make any calls and return an error that makes more sense. |
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
fc85404
to
3c16625
Compare
With binny v0.6.2 you don't need a GITHUB_TOKEN for installing or even updating tools sourced from a github release page 🎉 (I've also improved the error message when a token is not provided and there is a need to fall back to the v4 github api) |
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
* migrate to binny and taskfile Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * update binny to not require github token Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * added support for automatically building snapshots Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * detect source changes for snapshot builds Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fail workflow explicitly when snapshot cache restoral fails Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * match snapshot restoral paths Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This PR does two things primarily:
make ...
(slowly raises hand)..tool
instead of.tmp
.Example PR of the update bootstrap tools workflow: