Fall back to searching maven central using groupIDFromJavaMetadata #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
force-pushed
the
coheigea/groupIDFromJavaMetadata
branch
from
4c362ee
to
d21cef7
Compare
|
Waiting on #2302 to be merged first, I might tweak this as a result. |
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
coheigea
force-pushed
the
coheigea/groupIDFromJavaMetadata
branch
from
d21cef7
to
5db27bb
Compare
|
Ready for review @spiffcs |
spiffcs
approved these changes
Nov 11, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…nchore#2295) Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Java archive doesn't contain either a pom.xml or pom.properties or a license file, Syft doesn't find an associated license. This PR extends the functionality to search in maven central, this time using groupIDFromJavaMetadata, which can find the right group Id / artifact Id using information stored in the Java Manifest file.
With this PR Syft can find licenses for: