-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the power-user command and related catalogers #2306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
…mand Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
JSON schema diff for reviewers: # diff schema/json/schema-12.0.1.json schema/json/schema-13.0.0.json
3c3
< "$id": "anchore.io/schema/syft/json/12.0.1/document",
---
> "$id": "anchore.io/schema/syft/json/13.0.0/document",
392,397d391
< },
< "type": "array"
< },
< "secrets": {
< "items": {
< "$ref": "#/$defs/Secrets"
2111,2140d2104
< ]
< },
< "SearchResult": {
< "properties": {
< "classification": {
< "type": "string"
< },
< "lineNumber": {
< "type": "integer"
< },
< "lineOffset": {
< "type": "integer"
< },
< "seekPosition": {
< "type": "integer"
< },
< "length": {
< "type": "integer"
< },
< "value": {
< "type": "string"
< }
< },
< "type": "object",
< "required": [
< "classification",
< "lineNumber",
< "lineOffset",
< "seekPosition",
< "length"
2143,2160d2106
< "Secrets": {
< "properties": {
< "location": {
< "$ref": "#/$defs/Coordinates"
< },
< "secrets": {
< "items": {
< "$ref": "#/$defs/SearchResult"
< },
< "type": "array"
< }
< },
< "type": "object",
< "required": [
< "location",
< "secrets"
< ]
< },
|
spiffcs
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor and pruning going into syft v1.0.0.
…mand Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* remove the power-user command Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * remove secrets + classifier catalogers Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * bump json schema Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * regenerate json schema Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419
This PR:
power-user
commandsecrets
catalogerclassifier
catalogerpower-user
to tell the user that that command has been removed