Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the attest command #2337

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fix the attest command #2337

merged 5 commits into from
Nov 21, 2023

Conversation

wagoodman
Copy link
Contributor

Fixes #2333

This PR makes a few changes to the attest execution flow:

  • the cobra run function has now been decomposed into multiple smaller functions that are now under test
  • common elements to the packages command are now shared
  • the SBOM has been printing after the execution which is not intentional, this functionality has been removed so no SBOM is printed.
  • a notification at the end of successful output is shown how to access the attestation

@wagoodman
fix attest command
920c2dd 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman
add notification on how to access the attestation
3df74bd 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman requested a review from a team November 19, 2023 22:41
@wagoodman wagoodman self-assigned this Nov 19, 2023
@wagoodman
fix integration test
4440188 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman enabled auto-merge (squash) November 20, 2023 15:39
@wagoodman
Merge remote-tracking branch 'origin/main' into fix-attest
d1ddeb3 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
kzantow approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wagoodman
fix tests and allow for default json pretty option in api structs
3d6687e 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman merged commit 4712246 into main Nov 21, 2023
10 checks passed
@wagoodman wagoodman deleted the fix-attest branch November 21, 2023 18:29
@chenrui333 chenrui333 mentioned this pull request Nov 29, 2023
Merged
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Fix the attest command (anchore#2337)
45c8b11 
* fix attest command

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* add notification on how to access the attestation

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* fix integration test

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

---------

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

@wagoodman wagoodman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syft attest broken since 0.85.0
2 participants
@wagoodman @kzantow