Add the option to retrieve remote licenses for projects defined in a … #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
force-pushed
the
coheigea/maven-license-pom
branch
2 times, most recently
from
7387c0b
to
39e288d
Compare
…maven pom Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
coheigea
force-pushed
the
coheigea/maven-license-pom
branch
from
39e288d
to
2e40750
Compare
spiffcs
approved these changes
Dec 12, 2023
|
You're so awesome - thank you so much @coheigea for the improvements on this part of the code |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
… in a maven pom (anchore#2409) Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…maven pom
Similar to work I did to remotely retrieve licenses from Maven Central for dependencies in jars, this adds the same functionality when you're scanning a pom.xml instead. I moved the maven utilities from archive_parser into a separate file to maintain a cleaner separation.
You can reproduce with the project referenced on this issue #2266
Once PR is merged I'll look at getting the versions from the parent poms as well.