Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java cataloger miscellaneous fixes #245

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Java cataloger miscellaneous fixes #245

merged 4 commits into from
Oct 28, 2020

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Oct 28, 2020 •
edited

  • Adds a virtualPath for java archives to indicate if the archive was found within another java archive (similar to Anchore engine). e.g. hudson.war:WEB-INF/lib/args4j-2.0.16.jar
  • Removes the parentPackage from the json output for java archives
  • Removes optional fields from json output when empty
  • Parses java manifest sections separately; Fixes Java cataloger reporting packages without name and version #220
  • Forces lowercase of pom properties path variable

Partially addresses findings from anchore/grype#182 and anchore/grype#192 as well as helps with anchore/anchore-engine#681

@wagoodman
add java virtual path
76c8f24 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
update json schema and test for java virtualPath
8bcba7d 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
do not include optional fields
62f6146 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
remove parent java package from json && add java manifest section par…
2675891 
…sing

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the bug Something isn't working label Oct 28, 2020
@wagoodman wagoodman requested a review from a team October 28, 2020 21:26
@wagoodman wagoodman self-assigned this Oct 28, 2020
@wagoodman wagoodman changed the title Update java cataloger for engine Java cataloger miscellaneous fixes Oct 28, 2020
@wagoodman wagoodman merged commit 452426d into main Oct 28, 2020
@wagoodman wagoodman deleted the update-java-cataloger-for-engine branch October 28, 2020 21:36
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Merge pull request anchore#245 from anchore/update-java-cataloger-for…
38949d9 
…-engine

Java cataloger miscellaneous fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhring luhring luhring approved these changes

Assignees

@wagoodman wagoodman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java cataloger reporting packages without name and version
2 participants
@wagoodman @luhring