Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff error obfuscating binary test failures message #2468

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

LaurentGoderre
Copy link
Contributor

Before this change there were a lot of fatal errors

i.e.

Exception has occurred: panic
"MetadataType: does not exist"
Exception has occurred: panic
"cannot handle unexported field at Locations({pkg.Package}.Locations)...
Exception has occurred: panic
"cannot handle unexported field at {pkg.Package}.Licenses.set:\n\t\"g...

After the change:

Error:      	locations do not match; expected: haproxy1 got: haproxy

Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
@wagoodman wagoodman merged commit c72d295 into anchore:main Jan 4, 2024
10 checks passed
@LaurentGoderre LaurentGoderre deleted the fix-binary-ctaloger-test branch January 4, 2024 20:33
@wagoodman wagoodman added the bug Something isn't working label Jan 5, 2024
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants