Re-introduce linux kernel cataloger #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
add-linux-kernel-cataloger
branch
from
d3b6c63
to
3c07ce0
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
willmurphyscode
approved these changes
Jan 22, 2024
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* re-add linux kernel cataloger Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ensure there is at least a directory or image tag on each task Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix CLI tests to account for kernel finding (+2) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the linux kernel cataloger was inadvertently dropped from the list of catalogers to use when cataloging. This PR re-introduces that cataloger as well as adds two integration tests to defend against future regressions similar to this:
package_tasks.golocation where they are wiredEach test by itself has tradeoffs/assumptions (e.g. hard coded file paths, looking for function conventions by glob, etc.) but adding both helps reduce the risk of those assumptions.
Fixes #2524