Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to retrieve remote licenses from package-lock.json #2708

Merged
merged 1 commit into from Mar 21, 2024

Conversation

coheigea
Copy link
Contributor

Extending #2338 to also be able to retrieve remote licenses from package.lock. I only tested v2 package-lock.json.

@coheigea coheigea force-pushed the coheigea/package.lock-licenses branch from a1e2308 to 3fddabb Compare March 13, 2024 08:28
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
@coheigea coheigea force-pushed the coheigea/package.lock-licenses branch from 3fddabb to 32ea027 Compare March 13, 2024 09:58
@kzantow kzantow changed the title Adding the ability to retrieve remote licenses from package.lock Adding the ability to retrieve remote licenses from package-lock.json Mar 14, 2024
Copy link
Contributor

@spiffcs spiffcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @coheigea - LGTM 🟢

@spiffcs spiffcs merged commit f4e1896 into anchore:main Mar 21, 2024
11 checks passed
@coheigea coheigea deleted the coheigea/package.lock-licenses branch March 21, 2024 19:03
@spiffcs spiffcs added the enhancement New feature or request label Mar 25, 2024
brian-ebarb pushed a commit to brian-ebarb/syft that referenced this pull request Apr 17, 2024
…hore#2708)

Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants