Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary character in java version #2766

Merged
merged 3 commits into from Apr 11, 2024
Merged

Conversation

LaurentGoderre
Copy link
Contributor

Fixes #2750

@LaurentGoderre
Copy link
Contributor Author

This is just the failing test for now

@LaurentGoderre LaurentGoderre force-pushed the fix-2750 branch 2 times, most recently from 2724660 to 99d9916 Compare April 10, 2024 17:56
Fixes anchore#2750

Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
@LaurentGoderre
Copy link
Contributor Author

Fix is added

syft/pkg/cataloger/binary/classifiers.go Outdated Show resolved Hide resolved
syft/pkg/cataloger/binary/classifier_cataloger_test.go Outdated Show resolved Hide resolved
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow
Copy link
Contributor

kzantow commented Apr 10, 2024

@tbroyer after a talk with @LaurentGoderre I decided to take a stab at adding a negative matcher and updated things here; do the results match with what you're expecting to see now?

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Copy link

@tbroyer tbroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (from my understanding of the test harness, and what I remember from golang)

@kzantow kzantow merged commit c9aab48 into anchore:main Apr 11, 2024
11 checks passed
@LaurentGoderre LaurentGoderre deleted the fix-2750 branch April 11, 2024 14:34
brian-ebarb pushed a commit to brian-ebarb/syft that referenced this pull request Apr 17, 2024
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Co-authored-by: Keith Zantow <kzantow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 1.1 cataloging openjdk: generates version containing a null byte
4 participants