Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: repeatedly dereference pom variables #2781

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Fix: repeatedly dereference pom variables #2781

merged 5 commits into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. Fix: repeatedly dereference pom variables 

    Previously, if there was more than one layer of variable indirection in
the pom property (propert A says it has the same value as property B,
property B says it has the same value as property C), then Syft would
only dereference one layer. Add a loop to dereference variables until
either dereferencing fails, or until the variable is completely
dereferenced back to a literal.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    78dfa56 View commit details
    Browse the repository at this point in the history

  2. switch to recursive implementation 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e04f3b0 View commit details
    Browse the repository at this point in the history

  3. add test cases for degenerate poms 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f76aaba View commit details
    Browse the repository at this point in the history

  4. switch to recursive implementation 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4287fee View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. remove redundant pieces of test cases 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5a6995b View commit details
    Browse the repository at this point in the history