Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improvements to known CPE index construction #2801

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: improvements to known CPE index construction #2801

merged 2 commits into from
Apr 23, 2024

Commits on Apr 23, 2024

  1. fix: stop pre-filtering potential known CPE URLs 

    Previously when building the known CPE index, there was logic to
de-duplicate processing based on the normalized CPE name; however, this
means a significant number of known CPE's don't get indexed because the
first instance of that name didn't have a supported collection url but a
later one did.  This isn't code that executes at runtime in syft so
de-duplicating the processing for performance isn't really necessary
here and it doesn't add much to the total runtime anyways

Signed-off-by: Weston Steimel <commits@weston.slmail.me>
    @westonsteimel
    westonsteimel committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    508c07d View commit details
    Browse the repository at this point in the history

  2. fix: CPE index builder should extract and consider all reference urls 

    Previously the struct definition for CpeItem caused only the last URL
reference in the list to be kept and processed for inclusion in the
index

Signed-off-by: Weston Steimel <commits@weston.slmail.me>
    @westonsteimel
    westonsteimel committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0cf0f56 View commit details
    Browse the repository at this point in the history