Fix DecoderCollection discarding input from non-seekable Readers #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
reviewed
May 16, 2024
Signed-off-by: Russell Haering <russellhaering@gmail.com>
russellhaering
force-pushed
the
russell_h/fix_decoder_collection_seeking
branch
from
4456290
to
c0380ce
Compare
kzantow
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a
DecoderCollectionwould inadvertently consume from the input stream it was given while iterating through candidate formats, unless it was passed anio.ReadSeeker.This doesn't seem to currently affect the CLI.