Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Photon OS to the list of distros #341

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

thehh1974
Copy link

Signed-off-by: Haim Helman hhelman@vmware.com

@wagoodman wagoodman added the enhancement New feature or request label Mar 10, 2021
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, thanks for the contribution!

@alfredodeza
Copy link
Contributor

This looks good to me as well. I think we should capture the idea of relaxing the constraints here so that we rely on anything that /etc/os-release has - instead of requiring a type

@wagoodman
Copy link
Contributor

wagoodman commented Mar 10, 2021

This looks good to me as well. I think we should capture the idea of relaxing the constraints here so that we rely on anything that /etc/os-release has - instead of requiring a type

💯 ... @alfredodeza I think we have an opportunity to do that in some of the upcoming grype changes too. That is, migrate the specific types to grype (which is the only consumer interested in the types... syft does not internally use them). Just added #342 per your suggestion.

@alfredodeza
Copy link
Contributor

@thehh1974 this looks like it needs the latest changes from syft. Mind pulling those in and rebasing this branch? Thanks!

Signed-off-by: Haim Helman <hhelman@vmware.com>
@wagoodman
Copy link
Contributor

@thehh1974 the merge conflict on this branch was caused by me fixing the main branch. Since the refs at refs/pull are synthetic (read-only) I cannot force push a rebase. To fix this branch you will need to rebase on top of the latest changes on our main branch. My apologies for the extra work!

@thehh1974 thehh1974 force-pushed the add_photon_to_list_of_distros branch from 8351365 to 87e1a0f Compare March 12, 2021 16:35
@thehh1974
Copy link
Author

thehh1974 commented Mar 12, 2021 via email

@wagoodman wagoodman merged commit a83d79f into anchore:main Mar 16, 2021
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…_distros

Added Photon OS to the list of distros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants