Update package verification fields for DPKG #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
alfredodeza
suggested changes
Apr 9, 2021
Comment on lines
+71
to
+74
| if version != "" { | ||
| entry.SourceVersion = version | ||
| entry.Source = name | ||
| } |
There was a problem hiding this comment.
for my clarification only, this means that if version is empty, we don't want to capture the name?
There was a problem hiding this comment.
good question --I only migrated this part of the code (already existed in this file). Looks like it was added in #297 ... maybe an oversight?
There was a problem hiding this comment.
I didn't catch that this was migrated over. No strong opinions here, just that this looked odd. If you think this shouldn't get a bit reworked that's fine. If in doubt though, I'd recommend opening up a ticket to look at this later on (no need to block this PR on this)
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
alfredodeza
approved these changes
Apr 12, 2021
|
@alfredodeza created #377 |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ds-dpkg Update package verification fields for DPKG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggested improvements from #371 (comment), specifically:
conffilelisting to thefilesfield, combining information from both the status file and the info/conffilemd5field todigest, with subfieldsvalueandalgorithmDpkgMetadatachanges (which is a partially breaking change)artifacts.metadataanyOfclause was being generated incorrectly, resulting in an always-passing validation --this was fixed as well.Partially addresses #371