Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand RPM DB fields #387

Merged
merged 2 commits into from Apr 19, 2021
Merged

Expand RPM DB fields #387

merged 2 commits into from Apr 19, 2021

Conversation

wagoodman
Copy link
Contributor

Makes the following adjustments to the RPM DB cataloger:

  • adds username
  • adds groupname
  • adds file flags (c indicates conffile)
  • add digest algorithm
  • replaces the SHA256 field with the shared definition for file.Digest

Partially addresses #371

@wagoodman wagoodman requested a review from a team April 15, 2021 13:58
@wagoodman wagoodman self-assigned this Apr 15, 2021
@github-actions
Copy link

github-actions bot commented Apr 15, 2021

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           685µs ± 2%     928µs ± 1%  +35.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         857µs ± 4%    1119µs ± 1%  +30.62%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     358µs ± 3%     472µs ± 1%  +31.89%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 334µs ± 4%     449µs ± 3%  +34.42%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  353µs ± 3%     476µs ± 2%  +34.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  4.66ms ± 7%    6.25ms ± 0%  +34.00%  (p=0.016 n=5+4)
ImagePackageCatalogers/apkdb-cataloger-2                  521µs ± 8%     635µs ± 1%  +22.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     177µs ± 4%     237µs ± 2%  +34.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   278µs ± 4%     376µs ± 2%  +35.01%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          92.1kB ± 0%    92.0kB ± 0%   -0.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         480kB ± 0%     480kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     109kB ± 0%     109kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 114kB ± 0%     114kB ± 0%   -0.08%  (p=0.032 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  134kB ± 0%     134kB ± 0%   +0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.69MB ± 0%    1.69MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.13MB ± 0%    1.13MB ± 0%     ~     (p=0.802 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    47.8kB ± 0%    47.9kB ± 0%   +0.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                  87.3kB ± 0%    87.3kB ± 0%   -0.00%  (p=0.016 n=5+4)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           1.95k ± 0%     1.95k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         5.47k ± 0%     5.47k ± 0%     ~     (all equal)
ImagePackageCatalogers/javascript-package-cataloger-2     1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.36k ± 0%     2.36k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.18k ± 0%     3.19k ± 0%   +0.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                   22.0k ± 0%     22.0k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.79k ± 0%     1.79k ± 0%     ~     (p=0.556 n=5+4)
ImagePackageCatalogers/go-cataloger-2                     1.39k ± 0%     1.39k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.74k ± 0%     2.74k ± 0%     ~     (all equal)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman merged commit ecb16b6 into main Apr 19, 2021
Copy link
Contributor

@alfredodeza alfredodeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vhpy

@wagoodman wagoodman deleted the add-rpmdb-extra-fields branch April 19, 2021 20:41
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants