Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go mod tidy release problem #422

Merged
merged 2 commits into from
May 25, 2021
Merged

Fix go mod tidy release problem #422

merged 2 commits into from
May 25, 2021

Conversation

luhring
Copy link
Contributor

@luhring luhring commented May 25, 2021

Brings in go mod tidy fix from anchore/grype#323 (with minor update)

@luhring
Add go mod tidy check
c948542 
Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
@luhring
Run go mod tidy
ffdfdd8 
Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
@luhring luhring added the bug Something isn't working label May 25, 2021
@luhring luhring requested a review from a team May 25, 2021 21:03
@luhring luhring self-assigned this May 25, 2021
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           883µs ± 2%     939µs ± 2%  +6.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.18ms ± 2%    1.28ms ± 2%  +7.77%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     449µs ± 2%     470µs ± 4%  +4.66%  (p=0.016 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 421µs ± 1%     447µs ± 2%  +6.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  434µs ± 2%     465µs ± 2%  +7.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  5.81ms ± 1%    6.10ms ± 1%  +5.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  648µs ± 4%     676µs ± 1%  +4.32%  (p=0.016 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     221µs ± 3%     230µs ± 3%  +4.12%  (p=0.016 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   353µs ± 6%     373µs ± 2%  +5.51%  (p=0.032 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          97.5kB ± 0%    97.4kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         579kB ± 0%     579kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     112kB ± 0%     112kB ± 0%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 115kB ± 0%     115kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  134kB ± 0%     134kB ± 0%    ~     (p=0.135 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.78MB ± 0%    1.78MB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.14MB ± 0%    1.14MB ± 0%  -0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    48.3kB ± 0%    48.4kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                  88.9kB ± 0%    88.9kB ± 0%  +0.01%  (p=0.016 n=5+4)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           1.96k ± 0%     1.96k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         5.89k ± 0%     5.89k ± 0%    ~     (all equal)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.37k ± 0%     2.37k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.19k ± 0%     3.19k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   22.3k ± 0%     22.3k ± 0%    ~     (p=0.444 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.85k ± 0%     1.85k ± 0%    ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.40k ± 0%     1.40k ± 0%    ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.75k ± 0%     2.75k ± 0%    ~     (all equal)

@luhring luhring merged commit 8be0d98 into main May 25, 2021
@luhring luhring deleted the go-mod-tidy-fix branch May 25, 2021 21:13
@luhring luhring mentioned this pull request May 26, 2021
Merged
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@luhring
Fix go mod tidy release problem (anchore#422)
c4fe2c9 
* Add go mod tidy check

Signed-off-by: Dan Luhring <dan.luhring@anchore.com>

* Run go mod tidy

Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

@luhring luhring

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luhring @wagoodman