fix: update f1 score to not consider Label.Unclear as unlabeled matches #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
3 tasks
wagoodman
previously approved these changes
Oct 26, 2023
wagoodman
dismissed
their stale review
Can you add a test that reflects the change?
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs
commented
Oct 26, 2023
| @@ -195,7 +195,7 @@ def test_comparison_against_labels_indeterminate(): | |||
| m3_indeterminate = [ | |||
| artifact.LabelEntry( | |||
| label=artifact.Label.Unclear, | |||
| vulnerability_id="CVE-2021-2222", | |||
There was a problem hiding this comment.
note: this was changed so that it would now match against a vulnerability_id in the fixture. This test is effective since it shows the f1 score going up based on the change of Unclear being removed while also decreasing the amount of indeterminate found in the summary
|
Waiting for quality gate to pass before merging new changes |
wagoodman
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.