Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android+ios): add queryParameters and disableNativeRequests #6

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

mortend
Copy link
Contributor

@mortend mortend commented Nov 22, 2021

This patch will run native requests regardless of callbacks being set
or not, and adds two new fields in ModuleConfig:

  • queryParameters: Use this to provide custom query parameters for
    native requests.

  • disableNativeRequests: Set to true if you want to disable native
    requests. Remember to provide custom callbacks and call
    setPaymentResponse and setDetailsResponse. Unsafe! The JavaScript
    thread might get paused on Android!

This patch will run native requests regardless of callbacks being set
or not, and adds two new fields in ModuleConfig:

* queryParameters: Use this to provide custom query parameters for
  native requests.

* disableNativeRequests: Set to true if you want to disable native
  requests. Remember to provide custom callbacks and call
  setPaymentResponse and setDetailsResponse. **Unsafe! The JavaScript
  thread might get paused on Android!**
Copy link
Member

@jesperjohansson jesperjohansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jesperjohansson jesperjohansson merged commit 1400282 into ancon-labs:master Nov 23, 2021
@mortend mortend deleted the query-params branch November 23, 2021 08:47
@jesperjohansson jesperjohansson mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants