fix: sémantique du code est respectée (#403)

* fix: change button and link for accessibilite * fix: reverse data config * fix: use span instead of bold beacon
anct-cartographie-nationale · Dec 19, 2023 · 4c75c85 · 4c75c85
1 parent 74d15a2
commit 4c75c85
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/...components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html b/...components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html
@@ -37,14 +37,15 @@
     </button>
   </div>
   <div class="col">
-    <button
+    <a
+      role="button"
       type="button"
       class="btn btn-tile px-md-0 py-md-4 p-2 d-flex flex-md-column flex-row"
       (click)="sendByEmail.emit($event)">
       <span class="ri-circled bg-primary text-light fw-normal">
         <span role="img" class="ri-mail-send-line" aria-hidden="true"></span>
       </span>
       <span class="mt-md-2 mb-md-0 ms-md-0 ms-2 fw-bold">Envoyer par mail</span>
-    </button>
+    </a>
   </div>
 </div>
diff --git a/...ents/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html b/...ents/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html
@@ -54,7 +54,7 @@
       Webinaires : Mettre à jour vos données
     </span>
   </a>
-  <button slot="footer" type="submit" form="erreurGroup" class="btn btn-primary">
+  <button role="link" slot="footer" type="submit" form="erreurGroup" class="btn btn-primary">
     <span role="img" class="ri-mail-send-line" aria-hidden="true"></span>
     Signaler l'erreur
   </button>

diff --git a/.../lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html b/.../lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html
@@ -34,5 +34,8 @@
       </div>
     </div>
   </form>
-  <button slot="footer" type="submit" form="sendByEmailForm" class="btn btn-primary">Envoyer</button>
+  <button role="link" slot="footer" type="submit" form="sendByEmailForm" class="btn btn-primary">
+    <i class="ri-mail-send-line" aria-hidden="true"></i>
+    Envoyer
+  </button>
 </app-modal>
diff --git a/src/features/orientation/pages/accessibilite/accessibilite.page.html b/src/features/orientation/pages/accessibilite/accessibilite.page.html
@@ -73,7 +73,7 @@ <h1 class="h2 text-center fw-bold mt-sm-5 mt-3">
       </fieldset>
     </form>
     <div class="text-center mt-4">
-      <a class="btn btn-primary mx-3" [routerLink]="['..', 'disponibilite']" queryParamsHandling="preserve">
+      <a role="button" class="btn btn-primary mx-3" [routerLink]="['..', 'disponibilite']" queryParamsHandling="preserve">
         Suivant
         <span role="img" class="ri-arrow-right-s-line" aria-hidden="true"></span>
       </a>

diff --git a/src/features/orientation/pages/localisation/localisation.page.html b/src/features/orientation/pages/localisation/localisation.page.html
@@ -88,7 +88,7 @@ <h1 class="h2 text-center fw-bold mt-sm-5 mt-3">
       </div>
     </form>
     <div class="text-center mt-4">
-      <a class="btn btn-primary mx-3" [routerLink]="['..', 'accessibilite']" queryParamsHandling="preserve">
+      <a role="button" class="btn btn-primary mx-3" [routerLink]="['..', 'accessibilite']" queryParamsHandling="preserve">
         Suivant
         <span role="img" class="ri-arrow-right-s-line" aria-hidden="true"></span>
       </a>