feat: a11y of images from page presentation #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| <div class="row row-cols-1 row-cols-md-3 g-4 justify-content-center"> | |||
| <div class="col" *ngFor="let webinaire of webinairePresentation"> | |||
| <div class="card h-100 rounded-0"> | |||
| <img src="/assets/img/presentation/webinaire/{{ webinaire.image }}" class="w-100" alt="" /> | |||
| <img src="/assets/img/presentation/webinaire/{{ webinaire.image }}" class="w-100" alt="webinaire" /> | |||
There was a problem hiding this comment.
Suggested change
| <img src="/assets/img/presentation/webinaire/{{ webinaire.image }}" class="w-100" alt="webinaire" /> | |
| <img src="/assets/img/presentation/webinaire/{{ webinaire.image }}" class="w-100" alt="" /> |
C'est une image d'illustration, je ne pense pas que la lecture à haute voie de "webinaire" par un lecteur d'écran apporte une information importante à un public qui a besoin d'un tel outil pour naviguer sur le site.
Comment on lines
8
to
11
| <img | ||
| src="/assets/img/presentation/personnages_sur_carte.svg" | ||
| class="img-fluid" | ||
| alt="Personnages sur une carte géographique" /> |
There was a problem hiding this comment.
Suggested change
| <img | |
| src="/assets/img/presentation/personnages_sur_carte.svg" | |
| class="img-fluid" | |
| alt="Personnages sur une carte géographique" /> | |
| <img | |
| src="/assets/img/presentation/personnages_sur_carte.svg" | |
| class="img-fluid" | |
| alt="" /> |
La description est très bien, on peut bien se représenter ce qui existe sur l'image, mais il est important de ne décrire que les images qui apportent une information essentielle au contexte et qui n'est pas déjà accompagné d'un texte descriptif.
Ici, s'aggisant d'une image dont le seul but est d'illustrer la page, il n'y a pas besoin d'ajouter une description.
marc-gavanier
force-pushed
the
feat/a11y-presentation-page
branch
from
f36c2e8
to
b9088c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.