Django 1.6 compatibility #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not find where I can change the available versions of Django, if you help me with it will be good. |
mrsarm
reviewed
Jul 4, 2018
searchableselect/views.py
Outdated
|
|
||
| # Django 1.6.* | ||
| import django | ||
| if django.VERSION[0] == 1 and django.VERSION == 6: |
There was a problem hiding this comment.
Did you wanted to write django.VERSION[0] == 1 and django.VERSION[1] == 6 (missed [1]) ?
There was a problem hiding this comment.
Yes, it was be 4 a.m. Now I will correct
|
Guys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my old project on Django 1.6.5 very needed your useful widget and I make compatibility.
Django 1.6 not have JsonResponse and get_model taken next 2 arguments: app and model(may be this true for lower versions of Django, no tested). I think this patch does help other peoples with legacy projects.