Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

UI improvement request #155

Closed
caesarw opened this issue Mar 10, 2018 · 8 comments
Closed

UI improvement request #155

caesarw opened this issue Mar 10, 2018 · 8 comments
Assignees
Milestone

Comments

@caesarw
Copy link

caesarw commented Mar 10, 2018

Hey dear developers!

The app is very useful with its function and being open source. But for user interface there's a little imperfection.

The FAB menu is not very Material Design-ish . The label for menu options, the FAB menu animation and screen dimming still require improvement.

Thanks guys for hard work! 👍👍

@flocke flocke added this to the v0.4.2 milestone Mar 10, 2018
@flocke flocke self-assigned this Mar 10, 2018
@enwokoma
Copy link
Contributor

enwokoma commented Mar 10, 2018

Not bad, I've been wanting to make mention of this a long time ago! So, to add to this,

One major thing I would suggest concerning the FAB is that, the mainlayout of MainActivity should be dimmed/blurred whenever the FAB menu is open, outside this blurred background suggestion, I honestly see no need for any other improvements of the FAB in andOTP because it's not looking bad as it is currently!

Then another is concerning the animations in andOTP, I think those can be improved too, especially on the Intro Screen, this would help improve the User Experience of andOTP!

Then, I would suggest that a splash screen should be shown on the first run of every new update of andOTP, this Splash Screen should contain a list of What's New in the new update and a text below the screen showing the update version number, this screen should have a nice interactive (not necessarily animated) background and the What's New texts should be written in a nice font!

Another suggestion is that, we need to reduce the amount of dialog boxes in andOTP (especially for the open source licenses button, I really don't think using a dialog box to display the open source libraries used is necessary as there would probably be more libraries that would be integrated in the near future and a continuous use of a dialog box to display these licenses would make the dialog box too long and boring to read when more libraries are added to andOTP), so we need to consider using webviews/fragments or anything that feels better (take for instance, I believe that when the open source licenses button is clicked on, a fragment containing the names of all the libraries should be shown, each of those libraries listed should be clickable and when clicked, it should show another fragment containing the detailed information about that library and how it was used in andOTP) - Well, I think this particular suggestion might not be necessary though!

Then finally and most importantly, I believe and yet suggest that the QR code Scanner should be updated/changed, we need to use a better UI for the camera and QR code scanning feature!

In order to implement all these, we might consider the use proguard/dexguard in order to reduce the size of andOTP, this is necessary if we want to maintain the lightweight andOTP (below 10mb)

@enwokoma
Copy link
Contributor

I just made a pull request in #156 concerning showing our users an activity that contains a detailed What's New about every new update!

@flocke
Copy link
Member

flocke commented Mar 22, 2018

Let's just collect all requested changes in a short list:

  • Rework the FAB menu and make it more "material" (I'm probably just gonna replace my own quickly thrown together solution with this: https://github.com/jahirfiquitiva/FABsMenu)
  • (maybe) Replace the currently used dialog to display open source licenses with something nicer For now I just used a custom CSS to make the dialog a bit nicer to look at. To replace it we would have to switch to a completely new library, which I would like to postpone till after the next release.
  • (maybe) Make the UI of the QR scanner a bit nicer (since we use ZXing Android Embedded, which as far as I know is one of the best QR libraries out there, I will have to see how that could be done)

@flocke
Copy link
Member

flocke commented Mar 28, 2018

@enwokoma I created a separate branch to experiment a bit with AboutLibraries instead of the dialog, this is how it looks so far:

screenshot_andotp dev _20180328-132738
screenshot_andotp dev _20180328-132746

The idea to make it tabbed like this is taken from Transportr.

@flocke
Copy link
Member

flocke commented Apr 1, 2018

I still need to do some theming, the library cards are always white even on the two dark themes. Apart from that I think I will go with this design in the next release.

@enwokoma
Copy link
Contributor

enwokoma commented Apr 2, 2018 via email

@flocke
Copy link
Member

flocke commented Apr 3, 2018

Yeah, as far as I can tell AboutLibraries is used in a lot of stuff. That's why I picked it 😉

@flocke
Copy link
Member

flocke commented Apr 4, 2018

I've just finished theming everything and merged the aboutlibraries branch.

I won't be touching the QR code scanner for now as that would require more work and it looks fine in my opinion as it is.

@flocke flocke closed this as completed Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants