This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Add thumbnails for Heroku and npm #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we see if the NPM vector looks acceptable with a 198x198 size? Too big images can crash lower memory devices so I prefer to cap vectors at 256 by 256 |
|
@RichyHBM Resized the logo to 198x198, still looks acceptable on a high-res screen. Thanks. |
RichyHBM
reviewed
Jan 19, 2018
|
No particular reason. Caused by the toolchain I chose for scaling the SVG. Should be fixed now. |
|
OK, no worries! |
|
@flocke this looks good to merge in to me |
|
Sounds good. As always I'm not home over the weekend. Will merge it on Monday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add thumbnails for heroku (https://brand.heroku.com/) and npm (https://github.com/npm/logos).