#164069216 Create descriptive signup/registration validation error messages #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasibani-roy
requested review from
BagzieGracious,
CryceTruly,
joelethan,
marthamareal and
Peace-Apple
CryceTruly
reviewed
Feb 28, 2019
CryceTruly
reviewed
Feb 28, 2019
CryceTruly
reviewed
Feb 28, 2019
CryceTruly
reviewed
Feb 28, 2019
wasibani-roy
force-pushed
the
ft-validate-registration-data-164069216
branch
from
8a84a43
to
e8eadec
Compare
|
LGTM |
joelethan
previously approved these changes
Mar 4, 2019
wasibani-roy
dismissed stale reviews from Peace-Apple, joelethan, BagzieGracious, and CryceTruly
via
e48b4bb
wasibani-roy
force-pushed
the
ft-validate-registration-data-164069216
branch
6 times, most recently
from
4c953eb
to
2c89583
Compare
|
Good work Roy, however work on squashing the commits |
wasibani-roy
force-pushed
the
ft-validate-registration-data-164069216
branch
3 times, most recently
from
6b80943
to
42cf531
Compare
BagzieGracious
previously approved these changes
Mar 5, 2019
There was a problem hiding this comment.
good work @wasibani-roy, i have looked through it and its really working
| @@ -49,3 +42,27 @@ def test_email_exits(self): | |||
| self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) | |||
| self.assertEqual( | |||
| response.data['errors']['email'][0], "user with this email already exists.") | |||
|
|
|||
| def test_register_invalid_email(self): | |||
There was a problem hiding this comment.
Thanks for the hard, adding other tests and raising the test coverage. but please can you add doc strings for more clarity on your tests.
joelethan
previously approved these changes
Mar 5, 2019
- Ensure that email submitted by user is correct - Ensure that password is more than 8 characters and alphanumeric - Ensure the the email used has not been used to create a previous account - Ensure that the username is not already in use within the system [Finishes #164069216]
wasibani-roy
dismissed stale reviews from Peace-Apple, joelethan, CryceTruly, and BagzieGracious
via
9486d8e
wasibani-roy
force-pushed
the
ft-validate-registration-data-164069216
branch
from
42cf531
to
9486d8e
Compare
BagzieGracious
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
@wasibani-roy, i have reviewed your work, you have implemented all the feedback. Thanks for the good work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates validation/error messages to give users descriptive feedback on any errors encountered or success archived
Description of the tasks to be completed?
How should this be manually tested?
What are the relevant pivotal tracker stories?
Screenshots
