Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create user profile): Check who is updating a Profile #29

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

wasibani-roy
Copy link
Contributor

What does this PR do?

  • This PR ensures that only the user of the profile can update it

Description of Task to be completed?

  • A user should be able to only update his user profile

How should this be manually tested?

  • Clone the repo, cd into Ah-backend-aquaman and checkout the branch bg-fix-update-profile-164657442
  1. pip install -r requirements.txt
  2. python manage.py makemigrations
  3. python manage.py migrate
  4. python manage.py runserver
  5. Register and create an account

What are the relevant pivotal tracker stories?

- #164657442

Screenshots

Updating a profile thats not yours
Screenshot 2019-03-15 at 14 55 26

Updating your profile
Screenshot 2019-03-15 at 14 59 08

-Check to ensure the user updating the profile is the owner of that profile

[Starts #164657442]
@codeclimate
Copy link

codeclimate bot commented Mar 15, 2019

Code Climate has analyzed commit b4e2104 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Peace-Apple Peace-Apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Roy, It now works fine

@Peace-Apple
Copy link
Contributor

Wow, thanks for working on the email as well.

@marthamareal marthamareal merged commit 282db7c into develop Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants