#164069239 user should be able to highlight and comment on … #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagzieGracious
requested review from
CryceTruly,
joelethan,
marthamareal,
oryono,
Peace-Apple and
wasibani-roy
and removed request for
CryceTruly
BagzieGracious
force-pushed
the
ft-highlited-comment-164069239
branch
6 times, most recently
from
964c43b
to
fb4f682
Compare
Peace-Apple
previously approved these changes
Mar 21, 2019
BagzieGracious
force-pushed
the
ft-highlited-comment-164069239
branch
2 times, most recently
from
9520ba0
to
a61d1cb
Compare
wasibani-roy
previously approved these changes
Mar 21, 2019
Peace-Apple
previously approved these changes
Mar 21, 2019
joelethan
previously approved these changes
Mar 21, 2019
BagzieGracious
dismissed stale reviews from joelethan, Peace-Apple, and wasibani-roy
via
30a646d
BagzieGracious
force-pushed
the
ft-highlited-comment-164069239
branch
3 times, most recently
from
da20ca3
to
d746b40
Compare
wasibani-roy
previously approved these changes
Mar 21, 2019
|
@BagzieGracious great work, however, could you clear that 0002_auto_20190321_0950.py and have one migration file in articles, you could do this by deleting the migration file and its dependencies then migrate again. |
…text - Ensure that a user is able to highlight and comment on any text [Starts #164069239]
BagzieGracious
force-pushed
the
ft-highlited-comment-164069239
branch
from
d746b40
to
7fbb702
Compare
|
Code Climate has analyzed commit 7fbb702 and detected 0 issues on this pull request. View more on Code Climate. |
Peace-Apple
approved these changes
Mar 21, 2019
CryceTruly
approved these changes
Mar 21, 2019
wasibani-roy
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the user of a system to highlight and comment on any text in an article
Description of Task to be completed?
How should this be manually tested
Clone the repo and cd into Ah-backend-aquaman
git checkout ft-highlited-comment-164069239
pip install -r requirements.txt
python manage.py makemigrations
python manage.py migrate
python manage.py runserver
Register and then login into the system
The below endpoint will be used
Comment on highlighted text
Post http://127.0.0.1:8000/api/articleslug/comments/
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots