ch(test) Add frontend controller test units

- Mock http request for angular - write unit test cases for controller methods - modified controller methods to return promise [Finishes #158457036]
andela · Jul 12, 2018 · 7b11fff · 7b11fff
1 parent fcbbe72
commit 7b11fff
Show file tree

Hide file tree

Showing 24 changed files with 248 additions and 391 deletions.
diff --git a/.env 2 b/.env 2
diff --git a/.env.sample b/.env.sample
@@ -1,4 +1,4 @@
 MONGOHQ_URL_TEST=<Test database url>
-MONGOHQ_URL_DEV=<Development database url>
+MONGODB_URI=<Development database url>
 SECRET_KEY=<Secret key for JWT>
 GMAIL_PASSWORD=<password is pinned at slack channel>
diff --git a/.eslintrc.js → .eslintrc b/.eslintrc.js → .eslintrc
@@ -1,5 +1,5 @@
-module.exports = {
-    "root": true,
+{
+  "root": true,
   "extends": "airbnb-base",
   "env": {
     "node": true,
@@ -25,19 +25,23 @@ module.exports = {
       "requireReturnDescription": true
     }],
     "require-jsdoc": ["error", {
-        "require": {
-            "FunctionDeclaration": true,
-            "MethodDefinition": true,
-            "ClassDeclaration": true
-        }
+      "require": {
+        "FunctionDeclaration": true,
+        "MethodDefinition": true,
+        "ClassDeclaration": true
+      }
     }]
   },
   "globals": {
     "document": true,
-		"window": true,
-		"localStorage": true,
+    "window": true,
+    "localStorage": true,
     "FormData": true,
     "angular": true,
-    "$": true,
+    "require": true,
+    "describe": true,
+    "before": true,
+    "it": true,
+    "$": true
   }
-};
+}
diff --git a/app.json b/app.json
@@ -3,7 +3,7 @@
   "scripts": {
   },
   "env": {
-    "MONGOHQ_URL": {
+    "MONGODB_URI": {
       "required": true
     },
     "GMAIL_PASSWORD": {

diff --git a/backend-test/integration/findUsers.test.js b/backend-test/integration/findUsers.test.js
@@ -1,4 +1,3 @@
-import 'babel-polyfill';
 import request from 'supertest';
 import { expect } from 'chai';
 import mongoose from 'mongoose';
@@ -44,9 +43,9 @@ describe('User endpoints', () => {
     Promise.resolve(User.remove({}));
   });
 
-  it('GET /users/findUsers/:searchKey should return statusCode 200 with 2 users', (done) => {
+  it('GET /api/users/findUsers/:searchKey should return statusCode 200 with 2 users', (done) => {
     request(app)
-      .get('/users/findUsers/ben')
+      .get('/api/users/findUsers/ben')
       .set('Authorization', `Bearer ${token}`)
       .end((err, res) => {
         if (err) return done(err);
@@ -56,9 +55,9 @@ describe('User endpoints', () => {
       });
   });
 
-  it('GET /users/findUsers/:searchKey should return statusCode 200 with no user', (done) => {
+  it('GET /api/users/findUsers/:searchKey should return statusCode 200 with no user', (done) => {
     request(app)
-      .get('/users/findUsers/nothing')
+      .get('/api/users/findUsers/nothing')
       .set('Authorization', `Bearer ${token}`)
       .end((err, res) => {
         if (err) return done(err);

diff --git a/backend-test/integration/inviteUsers.test.js b/backend-test/integration/inviteUsers.test.js
@@ -1,4 +1,3 @@
-import 'babel-polyfill';
 import request from 'supertest';
 import { expect } from 'chai';
 import app from '../../server';
@@ -13,7 +12,7 @@ const user = {
 const token = Tokenizer(user);
 
 describe('User endpoints', () => {
-  it('POST /users/invite should return statusCode 200 with a user object', (done) => {
+  it('POST /api/users/invite should return statusCode 200 with a user object', (done) => {
     const payload = {
       user: {
         name: 'Ben Onah',
@@ -23,7 +22,7 @@ describe('User endpoints', () => {
       link: 'http://localhost:3333/app'
     };
     request(app)
-      .post('/users/invite')
+      .post('/api/users/invite')
       .set('Authorization', `Bearer ${token}`)
       .send(payload)
       .end((err, res) => {
@@ -34,7 +33,7 @@ describe('User endpoints', () => {
       });
   });
 
-  it('POST /users/invite should return statusCode 400 with error message if wrong email is used', (done) => {
+  it('POST /api/users/invite should return statusCode 400 with error message if wrong email is used', (done) => {
     const payload = {
       user: {
         name: 'Ben Onah',
@@ -44,7 +43,7 @@ describe('User endpoints', () => {
       link: 'http://localhost:3333/app'
     };
     request(app)
-      .post('/users/invite')
+      .post('/api/users/invite')
       .set('Authorization', `Bearer ${token}`)
       .send(payload)
       .end((err, res) => {
@@ -55,7 +54,7 @@ describe('User endpoints', () => {
       });
   });
 
-  it('POST /users/invite should return statusCode 400 with error message if wrong link is used', (done) => {
+  it('POST /api/users/invite should return statusCode 400 with error message if wrong link is used', (done) => {
     const payload = {
       user: {
         name: 'Ben Onah',
@@ -65,7 +64,7 @@ describe('User endpoints', () => {
       link: 'htt/localhost:3333/app'
     };
     request(app)
-      .post('/users/invite')
+      .post('/api/users/invite')
       .set('Authorization', `Bearer ${token}`)
       .send(payload)
       .end((err, res) => {

diff --git a/config/env/all.js b/config/env/all.js
@@ -7,5 +7,5 @@ dotenv.config();
 module.exports = {
   root: rootPath,
   port: process.env.PORT || 3000,
-  db: process.env.MONGOHQ_URL,
+  db: process.env.MONGODB_URI,
 };
diff --git a/config/env/development.js b/config/env/development.js
@@ -3,7 +3,7 @@ module.exports = {
     name: 'Cards for Humanity - Development'
   },
   port: process.env.PORT,
-  MONGOHQ_URL: process.env.MONGOHQ_URL_DEV,
+  MONGOHQ_URL: process.env.MONGODB_URI,
   facebook: {
     clientID: 'APP_ID',
     clientSecret: 'APP_SECRET',

diff --git a/config/env/production.js b/config/env/production.js
@@ -2,7 +2,7 @@ module.exports = {
   app: {
     name: 'Cards for Humanity'
   },
-  MONGOHQ_URL: process.env.MONGOHQ_URL,
+  MONGOHQ_URL: process.env.MONGODB_URI,
   facebook: {
     clientID: 'APP_ID',
     clientSecret: 'APP_SECRET',

diff --git a/config/routes.js b/config/routes.js
@@ -11,7 +11,10 @@ export default (router, passport, app) => {
   const api = Router();
   api
     .post('/auth/login', users.handleLogin)
-    .post('/auth/signup', users.handleSignUp);
+    .post('/auth/signup', users.handleSignUp)
+    .get('/users/findUsers/:searchKey', middleware.auth, users.findUsers)
+    .get('/users/findUsers/', middleware.auth, users.findUsers)
+    .post('/users/invite', middleware.auth, users.invite);
 
   router.get('/signin', users.signin);
   router.get('/signup', users.signup);
@@ -21,9 +24,6 @@ export default (router, passport, app) => {
   // Setting up the users api
   router.post('/users', users.create);
   router.post('/users/avatars', users.avatars);
-  router.get('/users/findUsers/:searchKey', middleware.auth, users.findUsers);
-  router.get('/users/findUsers/', middleware.auth, users.findUsers);
-  router.post('/users/invite', middleware.auth, users.invite);
 
   // Donation Routes
   router.post('/donations', users.addDonation);