#158457042 Bug fixes to the UI of the actual gaming screen #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bug with login and signup screen where error is not displayed when signing in or up - Fixed the avatar to reduce when on larger screen - Made sure all test are passing [Finishes #158457042]
- Changed the answer display color
- Added lines to the questions.
[Finishes #158457042]
bekomay26
force-pushed
the
ft-gaming-screen-ui-ux-158457042
branch
from
557f509
to
7dfea3f
Compare
bekomay26
changed the title
bekomay26
changed the title
- Changed the answer display color
- Added lines to the questions.
[Finishes #158457042]
- Update stylesheet
[Finishes #158457042]
Nkemjiks
force-pushed
the
ft-gaming-screen-ui-ux-158457042
branch
from
ea1cb1a
to
e7b4507
Compare
|
|
||
| $scope.closeReusedModal = function () { | ||
| $('#reuse-modal').modal('close'); | ||
| game.isFilledUp = null; |
There was a problem hiding this comment.
That is the function that Ikechukwu wrote. I just moved it to the invitePlayer controller since the test was not passing.
adetola-ralph
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Redesign issues on the gaming area of the application
Fix Redesign issues
How should this be manually tested?
Clone the repo. Run ’npm install’ and run ’npm start’. Visit ‘http://localhost:3000/’ and click on ‘Play as a guest’
Any background context you want to provide?
None
What are the relevant pivotal tracker stories?
#158457042