#1159067038 Unauthenticated User Should Not Save A Game #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenware
changed the title
kenware
force-pushed
the
bg-save-game-159067038
branch
from
947508b
to
08b730e
Compare
kenware
force-pushed
the
bg-save-game-159067038
branch
from
08b730e
to
d08f0c6
Compare
kenware
changed the title
-modify auth.js -modify angular controll and places conditional statement - Makes API call if a user is signed In [Finishes #159067038]
kenware
force-pushed
the
bg-save-game-159067038
branch
from
d08f0c6
to
435b173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes sure unauthenticated user does not make an API call to save a game
Description of Task to be completed?
Instead of returning status code 401 if a user is not signed In, an unauthenticated user should not make an API call
How should this be manually tested?
https://et-cfh-staging-pr-17.herokuapp.com/#!/app
Navigate to staging branch on Heroku, start a game when you are not logged in, There will be no API call to save a game
What are the relevant pivotal tracker stories?
#159067038 Unauthenticated user should not save a game
Any background context you want to add?
Screenshots