Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145186309 Fix accounts tests #8

Merged
10 commits merged into from
May 23, 2017
Merged

Conversation

jacksono
Copy link

What does this PR do?

  • Complete missing asserts on existing test cases for unit testing accounts module
  • Add new test cases to test the accounts module

Description of Task to be completed?

-Go through each test file and follow the instructions to fix the tests. The instructions are distributed throughout each file and the instruction lines begin with ##

How should this be manually tested?

  • Clone the repository
  • cd into the repository
  • run the command ./manage.py test hc.accounts

Any background context you want to provide?

  • There are five test files in the accounts app folder that had already created test cases with pssing tests, this ticket was to complete some missing asserts on existing test cases and add some new test cases as instructed in the respective test files preceded by ###

What are the relevant pivotal tracker stories?

  • #145186309

Screenshots (if appropriate)

screen shot 2017-05-22 at 12 34 38

@jacksono jacksono requested a review from a user May 22, 2017 09:45
@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage increased (+0.3%) to 80.851% when pulling dd65380 on ft-accounts-tests-fixes-145186309 into 121c195 on develop.

@ghost ghost merged commit 5eb79ea into develop May 23, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants