#141393367 Fixed accounts tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiodun0
suggested changes
Mar 27, 2017
| @@ -15,14 +15,29 @@ def test_it_shows_form(self): | |||
|
|
|||
| def test_it_redirects(self): | |||
| r = self.client.post("/accounts/check_token/alice/secret-token/") | |||
| self.assertEqual(r.status_code, 302) | |||
| # self.assertIn(self.profile.user, self.client.session) | |||
There was a problem hiding this comment.
CodeQuality: Nitpick
Remove commented out code
| self.profile.refresh_from_db() | ||
| self.assertEqual(self.profile.token, "") | ||
|
|
||
| ### Login and test it redirects already logged in | ||
| def test_redirects_already_logged_in(self): |
There was a problem hiding this comment.
Code Quality: Nitpick
this should be written like so
def test_redirects_if_already_logged_in
hc/accounts/tests/test_login.py
Outdated
| @@ -21,12 +22,21 @@ def test_it_sends_link(self): | |||
|
|
|||
| ### Assert that a user was created | |||
|
|
|||
| user_check = User.objects.filter(email="alice@example.org") | |||
There was a problem hiding this comment.
CodeQuality: Nitpick
Since you are getting only one value from the database this would be better as this
user = User.objects.get(email="alice@example.org")
So you avoid repitation on line 36
hc/accounts/tests/test_profile.py
Outdated
| @@ -42,9 +52,16 @@ def test_it_adds_team_member(self): | |||
|
|
|||
| ### Assert the existence of the member emails | |||
|
|
|||
| self.assertTrue("frank@example.org" in member_emails) | |||
| self.assertTrue("ben@example.org" in member_emails) | |||
There was a problem hiding this comment.
CodeQuaility: Nitpick
This code should be removed as it's just a smoke test
abiodun0
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.