-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#163519143] create user profile #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-create route -add controller -add middleware
-add request body validation -add some test
- add more test - enable user to use taken username and email
- add confirmation when user change email - add test '
oesukam
suggested changes
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nziranziza The route is working fine but you just need to add some empty lines at the end of some files that I commented on and also change your file tabulation space to 2 instead of 4
-add new line -solved eslint errors
-add new line -solved eslint errors
NkFab
approved these changes
Feb 14, 2019
oesukam
approved these changes
Feb 15, 2019
* reset-password(user): reset password reset via email - forget password endpoint - send reset password email to a user - reset password endpoint - send confirmation email to a user - unit test - increase test coverage - change response body - change status code - changing emails response [Delivers #163519140]
- add empty line
-create route -add controller -add middleware
-add request body validation -add some test
- add more test - enable user to use taken username and email
- add confirmation when user change email - add test '
-add new line -solved eslint errors
-add new line -solved eslint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add create profile
Description of Task to be completed?
How should this be manually tested?
send this as request body
N.B: Those fields are not mandatory and you can still add cover, bio and birthDate
What are the relevant pivotal tracker stories?
#163519143