Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#163519143] create user profile #14

Merged
merged 20 commits into from
Feb 19, 2019

Conversation

Nziranziza
Copy link
Contributor

What does this PR do?

Add create profile

Description of Task to be completed?

  • create middleware
  • add controller
  • add route
  • add test

How should this be manually tested?

  • git clone
  • npm install
  • npm run migrate
  • npm start
  • use postman add visit:
PUT api/v1/user

send this as request body

{
  "user":{
             "firstName":
             "lastName":
             "username":
             "email":
             "image":
         }
}

N.B: Those fields are not mandatory and you can still add cover, bio and birthDate

What are the relevant pivotal tracker stories?

#163519143

-create route
-add controller
-add middleware
-add request body validation
-add some test
- add more test
- enable user to use taken username and email
@Nziranziza Nziranziza requested review from NkFab, mcaleb808 and oesukam and removed request for NkFab and mcaleb808 February 14, 2019 12:07
@Nziranziza
Copy link
Contributor Author

@oesukam @NkFab can you review may PR?

@Nziranziza Nziranziza changed the title Ft create user profile 163519143 [#163519143] create user profile Feb 14, 2019
- add confirmation when user change email
- add test '
Copy link
Contributor

@oesukam oesukam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nziranziza The route is working fine but you just need to add some empty lines at the end of some files that I commented on and also change your file tabulation space to 2 instead of 4

routes/validators/user.js Outdated Show resolved Hide resolved
middlewares/verifyJwt.js Outdated Show resolved Hide resolved
__tests__/routes/profile.test.js Outdated Show resolved Hide resolved
routes/api/user.js Outdated Show resolved Hide resolved
-add new line
-solved eslint errors
-add new line
-solved eslint errors
mcaleb808 and others added 8 commits February 18, 2019 12:03
* reset-password(user): reset password reset via email

- forget password endpoint
- send reset password email to a user
- reset password endpoint
- send confirmation email to a user
- unit test
- increase test coverage
- change response body
- change status code
- changing emails response

[Delivers #163519140]
-create route
-add controller
-add middleware
-add request body validation
-add some test
- add more test
- enable user to use taken username and email
- add confirmation when user change email
- add test '
-add new line
-solved eslint errors
-add new line
-solved eslint errors
@kimotho-njoki kimotho-njoki merged commit 9f02953 into develop Feb 19, 2019
@kimotho-njoki kimotho-njoki deleted the ft-create-user-profile-163519143 branch February 19, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants