Skip to content

Commit

Permalink
chore(structure-data-flow): structure dataflow within the api
Browse files Browse the repository at this point in the history
- re-organize routing components

[Finishes #167036068]
  • Loading branch information
kodek-sleuth authored and dmithamo committed Jul 2, 2019
1 parent 43c0ce8 commit a3cd7a0
Show file tree
Hide file tree
Showing 8 changed files with 45 additions and 38 deletions.
Empty file added helpers/index.js
Empty file.
50 changes: 21 additions & 29 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import express from "express";
import bodyParser from "body-parser";
import session from "express-session";
import cors from "cors";
import swaggerUI from "swagger-ui-express";
import swagger from "./swaggerSetUp/ah-92explorers-api";
import welcomeRouter from "./routes/welcomeRouter";

import express from 'express';
import bodyParser from 'body-parser';
import cors from 'cors';
import swaggerUI from 'swagger-ui-express';
import morgan from 'morgan';
import swagger from './swaggerSetUp/ah-92explorers-api';
import router from './routes';
// Create global app object
const app = express();

Expand All @@ -14,32 +13,25 @@ app.use(cors());
// Normal express config defaults
app.use(bodyParser.urlencoded({ extended: false }));
app.use(bodyParser.json());
app.use(morgan('dev'));

app.use(require('method-override')());

app.use(require("method-override")());
app.use(express.static(__dirname + "/public"));
app.use(express.static(`${__dirname}/public`));

app.get("/swagger.json", (req, res) => {
res.setHeader("Content-Type", "application/json");
app.get('/swagger.json', (req, res) => {
res.setHeader('Content-Type', 'application/json');
res.send(swagger.swaggerSpec);
});
app.use("/docs", swaggerUI.serve, swaggerUI.setup(swagger.swaggerSpec));

app.use(
session({
secret: "authorshaven",
cookie: { maxAge: 60000 },
resave: false,
saveUninitialized: false
})
);
app.use('/docs', swaggerUI.serve, swaggerUI.setup(swagger.swaggerSpec));

require("./models/User");
require('./models/User');

app.use("/welcome", welcomeRouter);
app.use(router);

/// catch 404 and forward to error handler
app.use(function(_req, _res, next) {
const err = new Error("Not Found");
// / catch 404 and forward to error handler
app.use((_req, _res, next) => {
const err = new Error('Not Found');
err.status = 404;
next(err);
});
Expand All @@ -59,8 +51,8 @@ app.use((err, res) => {
});

// finally, let's start our server...
const server = app.listen(process.env.PORT || 3000, function() {
console.log("Listening on port " + server.address().port);
const server = app.listen(process.env.PORT || 3000, () => {
console.log(`Listening on port ${server.address().port}`);
});

export default app;
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "A Social platform for the creative at heart",
"main": "index.js",
"scripts": {
"start": "babel-node ./index.js",
"start": "nodemon ./index.js --exec babel-node",
"test": "NODE_ENV=test mocha --require @babel/register ./tests --timeout 10000 --exit",
"coveralls": "nyc npm test && nyc report --reporter=text-lcov | coveralls"
},
Expand Down
7 changes: 7 additions & 0 deletions routes/api/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
import express from 'express';
import welcome from './welcome';

const router = express.Router();

router.use('/', welcome);

export default router;
7 changes: 7 additions & 0 deletions routes/api/welcome.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import express from 'express';
import welcomeController from '../../controllers/welcomeController';

const router = express.Router();
router.get('/welcome', welcomeController.welcome);

export default router;
8 changes: 8 additions & 0 deletions routes/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import express from 'express';
import router from './api';

const route = express.Router();

route.use('/api/v1', router);

export default route;
7 changes: 0 additions & 7 deletions routes/welcomeRouter.js

This file was deleted.

2 changes: 1 addition & 1 deletion tests/welcome.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { assert } from 'chai';

describe('Express Server', () => {
it('should return 200', (done) => {
http.get('http://localhost:3000/welcome', (res) => {
http.get('http://localhost:3000/api/v1/welcome', (res) => {
assert.equal(200, res.statusCode);
done();
});
Expand Down

0 comments on commit a3cd7a0

Please sign in to comment.