#166790008 List Users Functionality #55

Hervera · 2019-07-20T06:53:53Z

What does this PR do?

Lists users functionality

Description of Task to be completed

add a route
add functionality of listing users
add tests
add a documentation

How should this be manually tested?

Run the following commands in the terminal

git clone https://github.com/andela/ah-92explorers-backend.git
cd ah-92explorers-backend
git checkout ft-list-users-functionality-166790008
npm install
npm start

Create a .env file and add the following snippets

DATABASE_URL=postgresql://dbusername:dbpassword@localhost:5432/dbname
DATABASE_TEST=postgresql://dbusername:dbpassword@localhost:5432/dbnamefortest
SECRET=whatever you want it to be

Install sequelize globally

sudo npm install -g sequelize

Create a database using sequelize db:create
Install and setup Postman to consume list users endpoint
Run the following requests in Postman using localhost:3000

Endpoint

Method	Endpoint	Task
`GET`	`/api/list-users`	`List users functionality`

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#166790008

Screenshots (if appropriate)

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I don't have more than 3 major commits on this PR

coveralls · 2019-07-20T06:57:56Z

Coverage decreased (-0.2%) to 91.983% when pulling 9bf0014 on ft-list-users-functionality-166790008 into 05b52b6 on develop.

niyoceles · 2019-07-20T10:14:37Z

controllers/ratings.js

@@ -0,0 +1,97 @@
+import models from '../models';


Remove this file ratings.js in controllers will no longer be used.

niyoceles · 2019-07-20T10:19:22Z

models/users.js

@@ -22,21 +24,26 @@ export default (sequelize, DataTypes) => {
        isEmail: true
      }
    },
-    provider: { type: DataTypes.STRING },


Please add this column on users table provider: { type: DataTypes.STRING },

elemanhillary-zz

ready for merge

elemanhillary-zz

resolve merge conflicts

request changes

hound · 2019-07-23T15:48:12Z

tests/rating.test.js

+        done();
+      });
+  });
+});


Newline required at end of file but not found eol-last

elemanhillary-zz

ready for merge

IsaiahRn

ready to be merged

elemanhillary-zz

ready for merge

IsaiahRn

fix merge conflicts

- add a route - add functionality of listing users - add tests - add a documentation [Finishes #166790008]

codeclimate · 2019-07-24T10:21:20Z

Code Climate has analyzed commit 9bf0014 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.5% (0.0% change).

View more on Code Climate.

elemanhillary-zz

ready for merge

Hervera requested review from kodek-sleuth, niyoceles and elemanhillary-zz and removed request for kodek-sleuth July 20, 2019 06:54

Hervera force-pushed the ft-list-users-functionality-166790008 branch from c588112 to 8f6acb9 Compare July 20, 2019 07:03

Hervera added the ready-for-review label Jul 20, 2019

niyoceles suggested changes Jul 20, 2019

View reviewed changes

Hervera requested a review from niyoceles July 23, 2019 07:45

Hervera force-pushed the ft-list-users-functionality-166790008 branch 2 times, most recently from 025c6cc to 211f37a Compare July 23, 2019 07:51

elemanhillary-zz approved these changes Jul 23, 2019

View reviewed changes

elemanhillary-zz previously approved these changes Jul 23, 2019

View reviewed changes

elemanhillary-zz self-requested a review July 23, 2019 15:20

Hervera force-pushed the ft-list-users-functionality-166790008 branch from 211f37a to 50f9dcb Compare July 23, 2019 15:48

hound bot reviewed Jul 23, 2019

View reviewed changes

tests/rating.test.js Outdated

done();

});

});

});

Copy link

hound bot Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last

Hervera force-pushed the ft-list-users-functionality-166790008 branch from 50f9dcb to 928797f Compare July 23, 2019 16:24

niyoceles previously approved these changes Jul 23, 2019

View reviewed changes

elemanhillary-zz previously approved these changes Jul 23, 2019

View reviewed changes

niyoceles added reviewed and removed ready-for-review labels Jul 23, 2019

IsaiahRn previously approved these changes Jul 23, 2019

View reviewed changes

Hervera dismissed stale reviews from IsaiahRn, elemanhillary-zz, and niyoceles via 712bb91 July 24, 2019 08:49

Hervera force-pushed the ft-list-users-functionality-166790008 branch from 928797f to 712bb91 Compare July 24, 2019 08:49

elemanhillary-zz self-requested a review July 24, 2019 08:56

elemanhillary-zz previously approved these changes Jul 24, 2019

View reviewed changes

IsaiahRn approved these changes Jul 24, 2019

View reviewed changes

niyoceles previously approved these changes Jul 24, 2019

View reviewed changes

IsaiahRn suggested changes Jul 24, 2019

View reviewed changes

feat(users): list users functionality

9bf0014

- add a route - add functionality of listing users - add tests - add a documentation [Finishes #166790008]

Hervera dismissed stale reviews from niyoceles and elemanhillary-zz via 9bf0014 July 24, 2019 10:18

Hervera force-pushed the ft-list-users-functionality-166790008 branch from 712bb91 to 9bf0014 Compare July 24, 2019 10:18

Hervera requested a review from IsaiahRn July 24, 2019 10:19

niyoceles approved these changes Jul 24, 2019

View reviewed changes

elemanhillary-zz approved these changes Jul 24, 2019

View reviewed changes

IsaiahRn approved these changes Jul 24, 2019

View reviewed changes

dmithamo merged commit 703a0fd into develop Jul 24, 2019

dmithamo deleted the ft-list-users-functionality-166790008 branch July 24, 2019 11:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#166790008 List Users Functionality #55

#166790008 List Users Functionality #55

Hervera commented Jul 20, 2019 •

edited

Loading

coveralls commented Jul 20, 2019 •

edited

Loading

niyoceles Jul 20, 2019

niyoceles Jul 20, 2019

elemanhillary-zz left a comment

elemanhillary-zz left a comment

hound bot Jul 23, 2019

elemanhillary-zz left a comment

IsaiahRn left a comment

elemanhillary-zz left a comment

IsaiahRn left a comment

codeclimate bot commented Jul 24, 2019

elemanhillary-zz left a comment

#166790008 List Users Functionality #55

#166790008 List Users Functionality #55

Conversation

Hervera commented Jul 20, 2019 • edited Loading

What does this PR do?

Description of Task to be completed

How should this be manually tested?

Endpoint

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Checklist

coveralls commented Jul 20, 2019 • edited Loading

niyoceles Jul 20, 2019

Choose a reason for hiding this comment

niyoceles Jul 20, 2019

Choose a reason for hiding this comment

elemanhillary-zz left a comment

Choose a reason for hiding this comment

elemanhillary-zz left a comment

Choose a reason for hiding this comment

hound bot Jul 23, 2019

Choose a reason for hiding this comment

elemanhillary-zz left a comment

Choose a reason for hiding this comment

IsaiahRn left a comment

Choose a reason for hiding this comment

elemanhillary-zz left a comment

Choose a reason for hiding this comment

IsaiahRn left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jul 24, 2019

elemanhillary-zz left a comment

Choose a reason for hiding this comment

Hervera commented Jul 20, 2019 •

edited

Loading

coveralls commented Jul 20, 2019 •

edited

Loading