Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162948918 Add article to favorites #28

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Conversation

tesh254
Copy link
Contributor

@tesh254 tesh254 commented Jan 31, 2019

What does this PR do?

Contains endpoints that allow a user to be able to add an article to their favourites, remove or get all favourites saved

Background tasks to be accomplished?

  • Favorite an article
  • Remove article from favorites
  • Get all favorites made by a user

How can this be manually tested?

  • Clone this repo
  • cd into project directory
  • Introduce a virtual environment python3 -m virtualenv venv
  • Activate your virtualenv
  • Install dependencies pip install -r requirements.txt
  • Run the application python3 manage.py runserver
  • Test manually these endpoints with postman
    • POST /api/v1/articles/<slug>/favorite/ Add article to favorites
    • POST /api/v1/articles/<slug>/unfavorite/ Remove article from favorites
    • GET /api/v1/favorites/ Get own favorites

Related pivotal tracker story?

#162948918

@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage decreased (-0.8%) to 93.446% when pulling f2bd2fd on ft-favorite-162948918 into c287e80 on develop.

Copy link

@frankip frankip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankip
Copy link

frankip commented Feb 12, 2019

@tesh254 Increase the coverage

- Setup files and folders to use
- Created endpoint to favorite an article
- Created endpoint to unfavorite an article
- Created endpoint to fetch all favorited articles
- Handle double favoriting

[Delivers #162948918]
@frankip frankip merged commit 0179319 into develop Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants