Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#164105567 Change image path type in article model #31

Merged
merged 2 commits into from
Feb 21, 2019
Merged

#164105567 Change image path type in article model #31

merged 2 commits into from
Feb 21, 2019

Conversation

boltonotieno
Copy link
Contributor

What does this PR do?

Changes image_path from ImageField to a character field

Description of Task(s) to be completed?

  • Change image_path from ImageField to a character field in both article model and serializer

What are the relevant pivotal tracker stories?

#164105567

Betty-Kebenei and others added 2 commits February 19, 2019 12:49
@Betty-Kebenei
Merge pull request #29 from andela/ft-custom-search-162948923
45d7952 
#162948923 custom search
@boltonotieno
bug(article): change image path type in the article model
bd58438 
-  change from ImageField to CharacterField

[Delivers #164105567]
danuluma
danuluma approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@danuluma danuluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ruiru11
Ruiru11 approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@Ruiru11 Ruiru11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work fixing the issue

@Betty-Kebenei Betty-Kebenei merged commit 510b467 into develop Feb 21, 2019
@Betty-Kebenei Betty-Kebenei deleted the bg-image-path-type-164105567 branch February 21, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danuluma danuluma danuluma approved these changes

@Ruiru11 Ruiru11 Ruiru11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boltonotieno @danuluma @Ruiru11 @Betty-Kebenei