Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162163269 Users can rate articles. #21

Merged
merged 8 commits into from
Dec 21, 2018
Merged

Conversation

KicaRonaldOkello
Copy link
Contributor

What does this PR do?
This PR ensures that an authenticated user can rate an article and also re-rate an article.
Description of Task to be completed?

  • A logged in user can rate an article.

  • A logged in user can re-rate an article

Endpoint working

  • POST "/api/articles/:slug/rate/"

How should this be manually tested?

  • Clone repository.
  • create virtual environment
  • Install requirements pip install -r requirements.txt - Run the project python manage.py runserver

Paste URL in postman: http://localhost:8000/api/articles/<slug>/rate/

Body in postman
{ "rating": 1 }

What are the relevant pivotal tracker stories?
#162163269
Screenshots:
image

@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 14, 2018 08:52 Inactive
@Kasulejoseph
Copy link
Collaborator

resolve the conflicts

@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 14, 2018 08:55 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 14, 2018 11:34 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:26 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:34 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:38 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:40 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:44 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:48 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 15, 2018 13:52 Inactive
@KicaRonaldOkello KicaRonaldOkello changed the title #162163269 Users can rate articles. #162163269 Users can rate articles.[WIP] Dec 15, 2018
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 17, 2018 08:54 Inactive
@bibangamba bibangamba had a problem deploying to ah-backend-athena-stagin-pr-21 December 17, 2018 13:23 Failure
@KicaRonaldOkello KicaRonaldOkello changed the title #162163269 Users can rate articles.[WIP] #162163269 Users can rate articles. Dec 17, 2018
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 17, 2018 13:26 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 17, 2018 13:29 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 17, 2018 13:32 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 17, 2018 13:38 Inactive
@bibangamba bibangamba had a problem deploying to ah-backend-athena-stagin-pr-21 December 17, 2018 14:04 Failure
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 18, 2018 08:55 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 19, 2018 05:11 Inactive
Copy link
Contributor

@kafuuma kafuuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this functionality with you and it works well

@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 19, 2018 15:34 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 20, 2018 02:20 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 20, 2018 02:27 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 20, 2018 13:57 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 20, 2018 14:08 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 20, 2018 14:12 Inactive
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 21, 2018 09:03 Inactive
This commit ensures that users are able to rate and re_rate articles.

[Delivers #162163269]
@bibangamba bibangamba temporarily deployed to ah-backend-athena-stagin-pr-21 December 21, 2018 09:11 Inactive
KicaRonaldOkello and others added 3 commits December 21, 2018 12:27
@collin5 collin5 merged commit 8cd6572 into develop Dec 21, 2018
@collin5 collin5 deleted the ft-rate-article-162163269 branch December 21, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants