#163249244 Correct typo in post deploy script in app.json to correct review app deployments #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect review app deployments changed ./manage to ./manage.py in post deploy script [Delivers #163249244]
bibangamba
force-pushed
the
bg-review-apps-deploy-script-163249244
branch
from
a005c4b
to
592a486
Compare
bibangamba
requested review from
Nta1e,
JaymesKat,
joshtrigger,
kafuuma,
Kasulejoseph,
KicaRonaldOkello and
SokoPaulSokool
Nta1e
approved these changes
Jan 16, 2019
kafuuma
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a typo in the
app.jsonfile. In the post-deploy script, change./manageto./manage.pyto enable Heroku complete the PR review app.Description of the tasks to be completed?
Correct the typo in the
app.jsonfile.How can this be manually tested?
A view deployment button should be available on this PR. It is the link for the deployed review app and will show that the bug is fixed.
What are the relevant pivotal stories?
#163249244