#162163258 Setup and deploy base application to Heroku #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy the base django application to heroku and enable review apps for each pull [Delivers #162163258]
Deploy the base django application to heroku and enable review apps for each pull Add app.json which is required to enable review apps [Delivers #162163258]
Deploy the base django application to heroku and enable review apps for each pull Add app.json which is required to enable review apps Add django-heroku to manage static files [Delivers #162163258]
Deploy the base django application to heroku and enable review apps for each pull Add app.json which is required to enable review apps Added .keep files to static folders so git can track them Removed django-heroku lib and and configs [Delivers #162163258]
Deploy the base django application to heroku and enable review apps for each pull Add app.json which is required to enable review apps Added django-heroku lib and config [Delivers #162163258]
Deploy the base django application to heroku and enable Review apps for each pull Add app.json which is required to enable review apps Added .keep files to static folders so git can track them Removed django-heroku lib and and configs Added AllowedHosts list [Delivers #162163258]
Deploy the base django application to heroku and enable
Review apps for each pull
Add app.json which is required to enable review apps
Added .keep files to static folders so git can track them
Removed django-heroku lib and and configs
Added AllowedHosts list
[Delivers #162163258]
Deploy the base django application to heroku and enable Review apps for each pull Add app.json which is required to enable review apps Added .keep files to static folders so git can track them Removed django-heroku lib and and configs Added AllowedHosts list [Delivers #162163258]
Deploy the base django application to heroku and enable
Review apps for each pull
Add app.json which is required to enable review apps
Added .keep files to static folders so git can track them
Removed django-heroku lib and and configs
Added AllowedHosts list
[Delivers #162163258]
Deploy the base django application to heroku and enable Review apps for each pull Add app.json which is required to enable review apps Added .keep files to static folders so git can track them Removed django-heroku lib and and configs Added AllowedHosts list [Delivers #162163258]
bibangamba
requested review from
Nta1e,
collin5,
joshtrigger,
KicaRonaldOkello,
Kasulejoseph,
kafuuma and
SokoPaulSokool
|
Awesome.. thanks for the good work |
Kasulejoseph
approved these changes
Nov 29, 2018
|
Good work |
Nta1e
approved these changes
Nov 30, 2018
kafuuma
approved these changes
Nov 30, 2018
|
great work andrew |
joshtrigger
approved these changes
Nov 30, 2018
KicaRonaldOkello
approved these changes
Nov 30, 2018
collin5
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request allows for Heroku deployment and enables creation of a review app on each pull request created
Description of tasks to be completed?
How should this be tested?
What are the relevant pivotal tracker stories
#162163258
Screenshots
This screenshot shows the working /admin page of the deployed app
This screenshot shows the pipeline and the different environments. ah-backend-athena-staging (STAGING) deploys from the develop branch while ah-backend-athena (PRODUCTION) deploys from the master branch
