Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reset password): user should be able to reset password #14

Merged
merged 1 commit into from
May 1, 2019

Conversation

joelmugaya
Copy link
Contributor

What does the PR do?

  • Adds endpoints for a user to reset his/her password.

Description of Task to be completed?

  • add password reset URLs
  • configure Django fixtures
  • add a database table to store reset tokens
  • add methods to handle password reset functionality
  • send reset token to user email
  • add functions to update the password
  • add tests

How should this be manually tested?

/api/reset_password/

{
	"email": "3dnamargarita@gmail.com"
}

/api/reset_password//

{
	"password": "987654321",
	"confirm_password": "987654321"
}

#165273473

Copy link
Contributor

@mwinel mwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it that this branch has no deployments?

@joelmugaya joelmugaya temporarily deployed to inviticus-staging-pr-14 April 30, 2019 11:55 Inactive
@joelmugaya
Copy link
Contributor Author

It is going to be deployed in a minute

@joelmugaya joelmugaya force-pushed the ft-users-able-reset-password-165273473 branch from 972a8bf to 3e97530 Compare April 30, 2019 13:19
@joelmugaya joelmugaya temporarily deployed to inviticus-staging-pr-14 April 30, 2019 13:19 Inactive
@joelmugaya joelmugaya force-pushed the ft-users-able-reset-password-165273473 branch from 3e97530 to 6f75552 Compare April 30, 2019 14:20
@joelmugaya joelmugaya temporarily deployed to inviticus-staging-pr-14 April 30, 2019 14:21 Inactive
Copy link
Contributor

@mwinel mwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for a merge.

@joelmugaya joelmugaya force-pushed the ft-users-able-reset-password-165273473 branch from 6f75552 to 6822f9f Compare April 30, 2019 19:46
@joelmugaya joelmugaya temporarily deployed to inviticus-staging-pr-14 April 30, 2019 19:46 Inactive
- add password reset urls
- configure django fixtures
- add database table to store reset tokens
- add methods to handle password reset functionality
- send reset token to user email
- add functions to update password
- add tests

[Delivers #165273473]
Copy link

@archibishop archibishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelmugaya LGTM I am merging this.

@archibishop archibishop merged commit bfc0d09 into develop May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants