#165890222 following and unfollowing users #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmugaya
changed the title
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
2 times, most recently
from
300b62e
to
d39817f
Compare
joelmugaya
requested review from
3Nakajugo,
KabohaJeanMark,
mwinel,
sanya-kenneth and
engjames
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
d39817f
to
cac131f
Compare
3Nakajugo
approved these changes
May 10, 2019
archibishop
reviewed
May 10, 2019
| profile = UserProfile.objects.get(user=value.follower) | ||
| profile = FetchUserProfileSerializer(profile) | ||
| profiles.append(profile.data) | ||
| return Response(profiles, status=status.HTTP_200_OK,) |
There was a problem hiding this comment.
@joelmugaya We should return a message You have no followers when the list being returned empty.
archibishop
reviewed
May 10, 2019
| profile = UserProfile.objects.get(user=value.followed) | ||
| profile = FetchUserProfileSerializer(profile) | ||
| profiles.append(profile.data) | ||
| return Response(profiles, status=status.HTTP_200_OK,) |
There was a problem hiding this comment.
@joelmugaya We should return a message You are following anyone. when the list being returned empty.
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
cac131f
to
9daafe3
Compare
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
9daafe3
to
d05d3f2
Compare
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
d05d3f2
to
a948a6d
Compare
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
a948a6d
to
eabd9da
Compare
- update profile model to include following functionality - update profile serializer to add a following field to the profile serialized data - write tests for the following functionality - add endpoints for the follow functionality to the url.py file - write functions to handle the follow functionlity [finishes #165890222]
joelmugaya
force-pushed
the
ft-users-able-follow-other-users-165890222
branch
from
eabd9da
to
3dcd6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Description of Task to be completed?
Tasks to be completed
How should this be manually tested?
POST /api/profiles/<username>/follow/returns"You are following username."GET /api/users/profile/<username>/returnsfollowing: TrueDELETE /api/profiles/<username>/follow/GET /api/profiles/<username>/followers/GET /api/profiles/<username>/following/[finishes #165890222]