#165273469 Add jwt authenticatication #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmugaya
reviewed
Apr 25, 2019
| message = "User does not exist in the database." | ||
| raise exceptions.AuthenticationFailed(message) | ||
| if not user.is_active: | ||
| message = "User is deactivated." |
There was a problem hiding this comment.
Return an appropriate message. eg.
Suggested change
| message = "User is deactivated." | |
| message = "User is not active." |
joelmugaya
reviewed
Apr 25, 2019
| @@ -1,3 +1,4 @@ | |||
| """Imports relevant to our class.""" | |||
There was a problem hiding this comment.
Thanks for adding a comment but try and avoid unnecessary changes
joelmugaya
reviewed
Apr 25, 2019
authors/apps/authentication/urls.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| """Import relevant dependencies.""" | |||
There was a problem hiding this comment.
Thanks for adding a comment but try and avoid unnecessary changes
joelmugaya
reviewed
Apr 25, 2019
requirements.txt
Outdated
| @@ -3,7 +3,6 @@ attrs==19.1.0 | |||
| certifi==2019.3.9 | |||
| chardet==3.0.4 | |||
| coverage==4.5.3 | |||
| coveralls==1.7.0 | |||
There was a problem hiding this comment.
We need this package please fix
engjames
force-pushed
the
ft-generate-jwt-token-165273469
branch
from
ebf57a7
to
9d13ab6
Compare
engjames
force-pushed
the
ft-generate-jwt-token-165273469
branch
from
9d13ab6
to
9f1d861
Compare
engjames
force-pushed
the
ft-generate-jwt-token-165273469
branch
from
9f1d861
to
baa6300
Compare
- Add PyJWT to requirements.txt file - Enable jwt authentication in settings.py - Modify urls to cater for jwt authentication - Add a method in the models that generates a token - Add a method to check and verify for authorization header - Return a response with a token, message and username upon successful generation. [Starts #165273469]
engjames
force-pushed
the
ft-generate-jwt-token-165273469
branch
from
baa6300
to
b46baed
Compare
archibishop
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
-Add a jwt authentication
Description of Task to be completed?
For a person to get a token, he has to first create an account using http://127.0.0.1:8000/api/users/
The body should be in the form
{
"user": {
"username": "francis",
"email": "francis@gmail.com",
"password": "123456789"
}
}
Then login to get a token using http://127.0.0.1:8000/api/users/login/
The body should be in the form
{
"user":{
"email": "francis@gmail.com",
"password": "123456789"
}
}
What are the relevant pivotal tracker stories?
#165273469
@joelmugaya @Baalmart @mwinel @3Nakajugo @sanya-kenneth @KabohaJeanMark @archbishop12 @