feat(signup-validations): Implement validations #10

huxaiphaer · 2018-09-05T19:52:38Z

What does this PR do?

Implements signup validation.

Description of Task to be completed?

Validating username, email, and password when the user is registering to the application.

How should this be manually tested?

This can be manually (locally) tested by using this URL http://127.0.0.1:8000/api/users/ with a POST method in Postman,
Then, you define your JSON body data as below to REGISTER.

{"user": {
                    "username": "lutaaya1" ,
                    "email": "lutaaya2@gmail.com",
                    "password": "12345554l"
          }
          
}

What are the relevant pivotal tracker stories?

159952001

coveralls · 2018-09-05T19:54:17Z

Pull Request Test Coverage Report for Build 267

46 of 50 (92.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 94.933%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
authors/apps/authentication/serializers.py	14	18	77.78%

Totals
Change from base Build 190:	-0.5%
Covered Lines:	356
Relevant Lines:	375

💛 - Coveralls

collinewait · 2018-09-06T07:05:44Z

Great work though code climate shows some mentainablity issues shown bellow:

collinewait · 2018-09-06T07:16:23Z

Travis is failing.

collinewait · 2018-09-06T07:09:05Z

authors/apps/authentication/tests/test_login_register.py

    def test_api_can_login_a_user(self):
        """Test the api can login a user."""
        self.response = self.client.post(
            "/api/users/login/",
-            self.login_data,


Why was this line deleted?

collinewait · 2018-09-06T07:11:59Z

authors/apps/authentication/tests/test_login_register.py

@@ -19,15 +19,15 @@ def setUp(self):
            self.user_data,
            format="json")

-    def test_api_can_register_a_user(self):


There was no need of deleting and rewriting the same test. The deleted test was reusing data in the base test file instead of rewriting similar data in the test.

i have solved this @collinewait

collinewait · 2018-09-06T07:14:31Z

authors/settings/base.py

@@ -20,7 +20,7 @@
 # See https://docs.djangoproject.com/en/1.11/howto/deployment/checklist/

 # SECURITY WARNING: keep the secret key used in production secret!
-SECRET_KEY = os.environ.get("SECRET_KEY", None)
+SECRET_KEY = os.environ.get("HOME", None)


What is the reason behind replacing "SECRET_KEY" with "HOME"?

reiosantos · 2018-09-06T13:59:53Z

I'm seeing 11 commits in your PR. could you please squash them together

huxaiphaer · 2018-09-06T14:13:58Z

@reiosantos , am on it

- Implementing all sign up validations tests and functionalities. [Finishes #159952001]

inno-asiimwe · 2018-09-07T08:28:55Z

authors/apps/authentication/tests/base_test.py

+
+        self.no_password_login = {
+            "user": {"email": self.user_email,
+                     "password": None,


Do we really need to pass none here?

I was still figuring out the way to get the validation error,

Estaer temporarily deployed to ah-backend-staging-pr-10 September 5, 2018 19:52 Inactive

Estaer temporarily deployed to ah-backend-staging-pr-10 September 5, 2018 19:56 Inactive

Estaer temporarily deployed to ah-backend-staging-pr-10 September 5, 2018 19:58 Inactive

huxaiphaer changed the title ~~implement validations~~ feat(signup-validations): Implement validations Sep 5, 2018

Estaer temporarily deployed to ah-backend-staging-pr-10 September 5, 2018 20:05 Inactive

collinewait reviewed Sep 6, 2018

View reviewed changes

Estaer temporarily deployed to ah-backend-staging-pr-10 September 6, 2018 07:56 Inactive

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 12:10 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 12:40 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 12:45 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 12:53 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 12:58 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 13:05 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from 70b7b98 to 37c7eb8 Compare September 6, 2018 14:20

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:21 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:36 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from a3e9edd to f47cf24 Compare September 6, 2018 14:40

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:41 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:50 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:55 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 14:58 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 15:05 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 15:06 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from 9111e3f to 61e6d2c Compare September 6, 2018 15:10

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 15:10 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 16:05 Failure

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 16:10 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from e1b6af1 to 20e6e89 Compare September 6, 2018 16:13

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 16:13 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from 20e6e89 to f3e615c Compare September 6, 2018 17:19

Estaer had a problem deploying to ah-backend-staging-pr-10 September 6, 2018 17:20 Failure

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from f3e615c to ffaf79f Compare September 6, 2018 17:28

Estaer temporarily deployed to ah-backend-staging-pr-10 September 6, 2018 17:28 Inactive

Estaer temporarily deployed to ah-backend-staging-pr-10 September 7, 2018 07:32 Inactive

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from 6c16699 to be9fe1d Compare September 7, 2018 07:54

Estaer deployed to ah-backend-staging-pr-10 September 7, 2018 07:54 View deployment

feature (signup validations): Implement validations

c4f58e2

- Implementing all sign up validations tests and functionalities. [Finishes #159952001]

huxaiphaer force-pushed the ft-signup-validation-errors-159952001 branch from be9fe1d to c4f58e2 Compare September 7, 2018 08:17

inno-asiimwe reviewed Sep 7, 2018

View reviewed changes

inno-asiimwe merged commit 030c961 into develop Sep 7, 2018

inno-asiimwe deleted the ft-signup-validation-errors-159952001 branch September 7, 2018 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(signup-validations): Implement validations #10

feat(signup-validations): Implement validations #10

huxaiphaer commented Sep 5, 2018 •

edited

Loading

coveralls commented Sep 5, 2018 •

edited

Loading

collinewait commented Sep 6, 2018 •

edited

Loading

collinewait commented Sep 6, 2018

collinewait Sep 6, 2018

collinewait Sep 6, 2018

huxaiphaer Sep 6, 2018

collinewait Sep 6, 2018

reiosantos commented Sep 6, 2018

huxaiphaer commented Sep 6, 2018

inno-asiimwe Sep 7, 2018 •

edited

Loading

huxaiphaer Sep 7, 2018

feat(signup-validations): Implement validations #10

feat(signup-validations): Implement validations #10

Conversation

huxaiphaer commented Sep 5, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

coveralls commented Sep 5, 2018 • edited Loading

Pull Request Test Coverage Report for Build 267

💛 - Coveralls

collinewait commented Sep 6, 2018 • edited Loading

collinewait commented Sep 6, 2018

collinewait Sep 6, 2018

Choose a reason for hiding this comment

collinewait Sep 6, 2018

Choose a reason for hiding this comment

huxaiphaer Sep 6, 2018

Choose a reason for hiding this comment

collinewait Sep 6, 2018

Choose a reason for hiding this comment

reiosantos commented Sep 6, 2018

huxaiphaer commented Sep 6, 2018

inno-asiimwe Sep 7, 2018 • edited Loading

Choose a reason for hiding this comment

huxaiphaer Sep 7, 2018

Choose a reason for hiding this comment

huxaiphaer commented Sep 5, 2018 •

edited

Loading

coveralls commented Sep 5, 2018 •

edited

Loading

collinewait commented Sep 6, 2018 •

edited

Loading

inno-asiimwe Sep 7, 2018 •

edited

Loading