-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jwt): Implement JWT strategy for authentication #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 175
💛 - Coveralls |
inno-asiimwe
suggested changes
Sep 6, 2018
|
||
class Meta: | ||
model = User | ||
# List all of the fields that could possibly be included in a request | ||
# or response, including fields specified explicitly above. | ||
fields = ['email', 'username', 'password'] | ||
fields = ['email', 'username', 'password', 'token'] | ||
#extra_kwargs = {'token': {'read_only': True}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this line in our codebase yet it is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am to remove it.
2a4d39e
to
9771fb2
Compare
- write unit tests - return a token upon user registration - return a token upon user login - implement a custom backend
93b66d0
to
2ae3182
Compare
inno-asiimwe
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Tasks to be completed?
How should this be manually tested?
After cloning the repo, cd into the directory.
Run
pip install -r requirements.txt
Use Postman to try out the endpoints.
/api/users/
endpoint for registration. Data format:/api/users/login/
endpoint for login. Data format:/api/user/
endpoint to for getting a current user. Authentication is required soadd the token in the header section after login.
What are the relevant pivotal tracker stories?
Screenshots