-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#160617684 Add functionality to show read time of an article #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12e3af0
to
b82fa98
Compare
b82fa98
to
752a679
Compare
- create articles app [DELIVERS #160617673] ft(upgrade):register articles app - add articles app to the settings of the app [DELIVERS #160617673] ft(upgrade):add url for articles - add url to authors project for hitting the articles app [DELIVERS #160617673] - change from createdAt to created_at, updatedAt to updated_at [DELIVERS #160617673] feat(upgrade):add generic views to create articles - modify views.py to use generic functions [DELIVERS #160617673] feat(upgrade):modify serializers to return list - import returnlist to serializers.py [DELIVERS #160617673] feat(upgrade):add view for retrieve and delete - overide the generic views functions - modify views to use generic views - modify serializers to have slug, authors field to readonly - add test module for articles [DELIVERS #160617673] feat(addtests):add tests for articles - add tests for create,update,retrieve and delete an article - add tests for unauthorized users not delete, create and update - register articles app with admin [DELIVERS #160617673]
- create articles app [DELIVERS #160617673] ft(upgrade):register articles app - add articles app to the settings of the app [DELIVERS #160617673] ft(upgrade):add url for articles - add url to authors project for hitting the articles app [DELIVERS #160617673] - change from createdAt to created_at, updatedAt to updated_at [DELIVERS #160617673] feat(upgrade):add generic views to create articles - modify views.py to use generic functions [DELIVERS #160617673] feat(upgrade):modify serializers to return list - import returnlist to serializers.py [DELIVERS #160617673] feat(upgrade):add view for retrieve and delete - overide the generic views functions - modify views to use generic views - modify serializers to have slug, authors field to readonly - add test module for articles [DELIVERS #160617673]
- add functionality to show read time of an article [DELIVERS #160617673] ft(upgrade):add articles app to authors project for creating articles - create articles app [DELIVERS #160617673] ft(upgrade):register articles app - add articles app to the settings of the app [DELIVERS #160617673] ft(upgrade):add url for articles - add url to authors project for hitting the articles app [DELIVERS #160617673] - change from createdAt to created_at, updatedAt to updated_at [DELIVERS #160617673] feat(upgrade):add generic views to create articles - modify views.py to use generic functions [DELIVERS #160617673] feat(upgrade):modify serializers to return list - import returnlist to serializers.py [DELIVERS #160617673] feat(upgrade):add view for retrieve and delete - overide the generic views functions - modify views to use generic views - modify serializers to have slug, authors field to readonly - add test module for articles [DELIVERS #160617673] ft(upgrade):add articles app to authors project for creating articles - create articles app [DELIVERS #160617673] ft(upgrade):register articles app - add articles app to the settings of the app [DELIVERS #160617673] ft(upgrade):add url for articles - add url to authors project for hitting the articles app [DELIVERS #160617673] - change from createdAt to created_at, updatedAt to updated_at [DELIVERS #160617673] feat(upgrade):add generic views to create articles - modify views.py to use generic functions [DELIVERS #160617673] feat(upgrade):modify serializers to return list - import returnlist to serializers.py [DELIVERS #160617673] feat(upgrade):add view for retrieve and delete - overide the generic views functions [DELIVERS #160617673] ft(upgrade): add read time field [DELIVERS #160617684] ft(readtime): add read time field to article - add method to calculate read time in models [DELIVERS #160617684] ft(readtime): add read time feature - add function to calculate time - add field to returned data [DELIVERS #160617684]
752a679
to
3c2b8c2
Compare
PatrickCmd
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)