Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160617684 Add functionality to show read time of an article #22

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

kimbugp
Copy link
Contributor

@kimbugp kimbugp commented Oct 11, 2018

What does this PR do?

  • Calculate the time taken to read an article

Description of Task to be completed?

  • when you create an article,it gets the body and calculated the time it will take to read it using an algorithm

What are the relevant pivotal tracker stories?

  • #160617684

Screenshots (if appropriate)

  • On creating article,the time is calculated

screen shot 2018-10-11 at 17 38 40

  • longer body means longer read time

screen shot 2018-10-11 at 17 41 03

  • On editing article ,time is recalculated

screen shot 2018-10-11 at 17 41 52

@nakiwuge nakiwuge temporarily deployed to ah-backend-lannister-sta-pr-22 October 11, 2018 14:47 Inactive
@coveralls
Copy link

coveralls commented Oct 11, 2018

Coverage Status

Coverage decreased (-0.02%) to 95.387% when pulling 3c2b8c2 on ft-article-read-time-160617684 into 94e67fb on develop.

@kimbugp kimbugp force-pushed the ft-article-read-time-160617684 branch from 12e3af0 to b82fa98 Compare October 11, 2018 16:29
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-22 October 11, 2018 16:29 Inactive
@andela andela deleted a comment from coveralls Oct 11, 2018
@kimbugp kimbugp force-pushed the ft-article-read-time-160617684 branch from b82fa98 to 752a679 Compare October 11, 2018 18:47
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-22 October 11, 2018 18:47 Inactive
Amos Welike added 3 commits October 12, 2018 12:07
- create articles app

[DELIVERS #160617673]

ft(upgrade):register articles app

- add articles app to the settings of the app

[DELIVERS #160617673]

ft(upgrade):add url for articles

- add url to authors project for hitting the articles app

[DELIVERS #160617673]

- change from createdAt to created_at, updatedAt to updated_at

[DELIVERS #160617673]

feat(upgrade):add generic views to create articles

- modify views.py to use generic functions

[DELIVERS #160617673]

feat(upgrade):modify serializers to return list

- import returnlist to serializers.py

[DELIVERS #160617673]

feat(upgrade):add view for retrieve and delete

- overide the generic views functions
- modify views to use generic views
- modify serializers to have slug, authors field to readonly
- add test module for articles

[DELIVERS #160617673]

feat(addtests):add tests for articles

- add tests for create,update,retrieve and delete an article
- add tests for unauthorized users not delete, create and update
- register articles app with admin

[DELIVERS #160617673]
- create articles app

[DELIVERS #160617673]

ft(upgrade):register articles app

- add articles app to the settings of the app

[DELIVERS #160617673]

ft(upgrade):add url for articles

- add url to authors project for hitting the articles app

[DELIVERS #160617673]

- change from createdAt to created_at, updatedAt to updated_at

[DELIVERS #160617673]

feat(upgrade):add generic views to create articles

- modify views.py to use generic functions

[DELIVERS #160617673]

feat(upgrade):modify serializers to return list

- import returnlist to serializers.py

[DELIVERS #160617673]

feat(upgrade):add view for retrieve and delete

- overide the generic views functions
- modify views to use generic views
- modify serializers to have slug, authors field to readonly
- add test module for articles

[DELIVERS #160617673]
- add functionality to show read time of an article

[DELIVERS #160617673]

ft(upgrade):add articles  app to authors project for creating articles

- create articles app
[DELIVERS #160617673]

ft(upgrade):register articles app

- add articles app to the settings of the app

[DELIVERS #160617673]

ft(upgrade):add url for articles

- add url to authors project for hitting the articles app

[DELIVERS #160617673]

- change from createdAt to created_at, updatedAt to updated_at

[DELIVERS #160617673]

feat(upgrade):add generic views to create articles

- modify views.py to use generic functions

[DELIVERS #160617673]

feat(upgrade):modify serializers to return list

- import returnlist to serializers.py

[DELIVERS #160617673]

feat(upgrade):add view for retrieve and delete

- overide the generic views functions
- modify views to use generic views
- modify serializers to have slug, authors field to readonly
- add test module for articles

[DELIVERS #160617673]

ft(upgrade):add articles  app to authors project for creating articles

- create articles app

[DELIVERS #160617673]

ft(upgrade):register articles app

- add articles app to the settings of the app

[DELIVERS #160617673]

ft(upgrade):add url for articles

- add url to authors project for hitting the articles app

[DELIVERS #160617673]

- change from createdAt to created_at, updatedAt to updated_at

[DELIVERS #160617673]

feat(upgrade):add generic views to create articles

- modify views.py to use generic functions

[DELIVERS #160617673]

feat(upgrade):modify serializers to return list

- import returnlist to serializers.py

[DELIVERS #160617673]

feat(upgrade):add view for retrieve and delete

- overide the generic views functions

[DELIVERS #160617673]

ft(upgrade): add read time field

[DELIVERS #160617684]

ft(readtime): add read time field to article

- add method to calculate read time in models

[DELIVERS #160617684]

ft(readtime): add read time feature

- add function to calculate time
- add field to returned data

[DELIVERS #160617684]
Copy link
Contributor

@PatrickCmd PatrickCmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrickCmd PatrickCmd merged commit 8b1ab14 into develop Oct 12, 2018
@PatrickCmd PatrickCmd deleted the ft-article-read-time-160617684 branch October 17, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants