Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160617687 Users should be able to report an article #43

Merged
merged 1 commit into from
Oct 19, 2018
Merged

#160617687 Users should be able to report an article #43

merged 1 commit into from
Oct 19, 2018

Conversation

kcharles52
Copy link
Contributor

What does this PR do?

  • It ensure that an authenticated user is able to report an article
  • It ensures that an admin views all the reported articles

Description of Task to be completed?

  • As an authenticated user I should be able to report articles that violate terms of agreement or are plagiarised to the authors haven admin for removal and or any other actions as per the terms of engagement

How should this be manually tested?

  • viewing reported articles go to /api/escalations/
  • viewing summary of reported articles /api/escalations/report/
  • reporting an article go to /api/articles/<str:article_slug>/report/

Screenshots

  • view all reported articles

screen shot 2018-10-18 at 18 02 55

  • summary of reported articles

screen shot 2018-10-18 at 18 00 35

  • report an article

screen shot 2018-10-18 at 18 23 54

[DELIVERS #160617687]

@nakiwuge nakiwuge temporarily deployed to ah-backend-lannister-sta-pr-43 October 18, 2018 15:25 Inactive
@coveralls
Copy link

coveralls commented Oct 18, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 95.018% when pulling e67d9fa on ft-report-article-160617687 into 08e26f9 on develop.

kimbugp
kimbugp reviewed Oct 18, 2018
View reviewed changes
Copy link
Contributor

@kimbugp kimbugp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimbugp kimbugp added the ready PR is ready for merging label Oct 18, 2018
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-43 October 19, 2018 05:35 Inactive
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-43 October 19, 2018 05:39 Inactive
@kimbugp kimbugp force-pushed the ft-report-article-160617687 branch 2 times, most recently from d371b81 to ac3a622 Compare October 19, 2018 07:15
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-43 October 19, 2018 07:15 Inactive
@kimbugp kimbugp temporarily deployed to ah-backend-lannister-sta-pr-43 October 19, 2018 07:37 Inactive
@kimbugp
ft(escalating): add feature to report article
e67d9fa 
- add model for reported articles
- add serializer for reported articles
- add view to report articles
- add  url to report articles
- perform flake8 corrections

[DELIVERS #160617687]

ft(escalating): correct migrations

-correct migrations

[FIXES #160617687]

ft(escalating): escalations

- add admin access

[DELIVERS #160617687]

ft(escalating): escalations

- add times article
- add report article serializer
- add report article urls
- add report view
- add migrations
- add tests for the feature

[DELIVERS #160617687]
@PatrickCmd PatrickCmd merged commit 364e360 into develop Oct 19, 2018
@PatrickCmd PatrickCmd deleted the ft-report-article-160617687 branch October 22, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbugp kimbugp kimbugp left review comments

@PatrickCmd PatrickCmd PatrickCmd approved these changes

@AmosWels AmosWels Awaiting requested review from AmosWels

Assignees
No one assigned
Labels
ready PR is ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kcharles52 @coveralls @PatrickCmd @kimbugp @nakiwuge